[None][chore] Update .gitattributes by ziyixiong-nv · Pull Request #15606 · NVIDIA/TensorRT-LLM

ziyixiong-nv · 2026-06-25T00:47:43Z

Summary by CodeRabbit

Chores
- Updated repository rules for handling ZIP artifacts used in integration examples, aligning them with the current file location.

Description

Test Coverage

PR Checklist

Please review the following before submitting your PR:

PR description clearly explains what and why. If using CodeRabbit's summary, please make sure it makes sense.
PR Follows TRT-LLM CODING GUIDELINES to the best of your knowledge.
Test cases are provided for new code paths (see test instructions)
If PR introduces API changes, an appropriate PR label is added - either api-compatible or api-breaking. For api-breaking, include BREAKING in the PR title.
Any new dependencies have been scanned for license and vulnerabilities
CODEOWNERS updated if ownership changes
Documentation updated as needed
Update tava architecture diagram if there is a significant design change in PR.
The reviewers assigned automatically/manually are appropriate for the PR.
Please check this after reviewing the above items as appropriate for this PR.

GitHub Bot Help

To see a list of available CI bot commands, please comment /bot help.

ziyixiong-nv · 2026-06-25T00:47:57Z

/bot run

tensorrt-cicd · 2026-06-25T00:54:44Z

PR_Github #55634 [ run ] triggered by Bot. Commit: ea28608 Link to invocation

ziyixiong-nv · 2026-06-25T01:58:51Z

/bot run --disable-fail-fast

coderabbitai · 2026-06-25T01:59:06Z

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info

⚙️ Run configuration

Configuration used: Path: .coderabbit.yaml

Review profile: CHILL

Plan: Enterprise

Run ID: 2384ad40-7269-46e3-a4f0-168b9471238b

📥 Commits

Reviewing files that changed from the base of the PR and between 158d684 and 19f9710.

⛔ Files ignored due to path filters (1)

tests/integration/defs/examples/visual_gen/golden/visual_gen_lpips/visual_gen_lpips_golden_media.zip is excluded by !**/*.zip

📒 Files selected for processing (1)

.gitattributes

📝 Walkthrough

Walkthrough

Updated the .gitattributes Git LFS rule for visual_gen_lpips ZIP artifacts to match the new golden file location pattern.

Changes

Git LFS glob update

Layer / File(s)	Summary
Update LFS glob `.gitattributes`	The LFS rule for `visual_gen_lpips` ZIP files now targets `tests/integration/defs/examples/visual_gen/golden/visual_gen_lpips/*.zip` instead of the previous path.

Estimated code review effort

🎯 1 (Trivial) | ⏱️ ~2 minutes

🚥 Pre-merge checks | ✅ 4 | ❌ 1

❌ Failed checks (1 warning)

Check name	Status	Explanation	Resolution
Description check	⚠️ Warning	The description is still the template text; the Description and Test Coverage sections are empty.	Add a brief problem/solution summary and include relevant tests or explain why none were needed.

✅ Passed checks (4 passed)

Check name	Status	Explanation
Title check	✅ Passed	The title is concise and matches the main visible change to .gitattributes.
Docstring Coverage	✅ Passed	No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Linked Issues check	✅ Passed	Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check	✅ Passed	Check skipped because no linked issues were found for this pull request.

_{✏️ Tip: You can configure your own custom pre-merge checks in the settings.}

✨ Finishing Touches

🧪 Generate unit tests (beta)

Create PR with unit tests

_{Comment @coderabbitai help to get the list of available commands.}

tensorrt-cicd · 2026-06-25T02:04:41Z

PR_Github #55656 [ run ] triggered by Bot. Commit: 19f9710 Link to invocation

tensorrt-cicd · 2026-06-25T02:09:38Z

PR_Github #55634 [ run ] completed with state ABORTED. Commit: ea28608

Link to invocation

ziyixiong-nv · 2026-06-25T02:17:20Z

/bot run --disable-fail-fast

tensorrt-cicd · 2026-06-25T02:25:43Z

PR_Github #55664 [ run ] triggered by Bot. Commit: 19f9710 Link to invocation

tensorrt-cicd · 2026-06-25T02:28:59Z

PR_Github #55656 [ run ] completed with state ABORTED. Commit: 19f9710

Link to invocation

ziyixiong-nv · 2026-06-25T02:34:52Z

/bot run --disable-fail-fast

tensorrt-cicd · 2026-06-25T02:40:59Z

PR_Github #55669 [ run ] triggered by Bot. Commit: 19f9710 Link to invocation

tensorrt-cicd · 2026-06-25T02:44:10Z

PR_Github #55664 [ run ] completed with state ABORTED. Commit: 19f9710

Link to invocation

tensorrt-cicd · 2026-06-25T06:59:18Z

PR_Github #55669 [ run ] completed with state FAILURE. Commit: 19f9710
/LLM/main/L0_MergeRequest_PR pipeline #44575 completed with status: 'FAILURE'

CI Report

⚠️ Action Required:

Please check the failed tests and fix your PR
If you cannot view the failures, ask the CI triggerer to share details
Once fixed, request an NVIDIA team member to trigger CI again

CI Agent Failure Analysis

Link to invocation

ziyixiong-nv · 2026-06-25T07:10:47Z

/bot run

tensorrt-cicd · 2026-06-25T07:17:26Z

PR_Github #55737 [ run ] triggered by Bot. Commit: 19f9710 Link to invocation

tensorrt-cicd · 2026-06-25T08:07:41Z

PR_Github #55737 [ run ] completed with state SUCCESS. Commit: 19f9710
/LLM/main/L0_MergeRequest_PR pipeline #44640 completed with status: 'FAILURE'

CI Report

⚠️ Action Required:

Please check the failed tests and fix your PR
If you cannot view the failures, ask the CI triggerer to share details
Once fixed, request an NVIDIA team member to trigger CI again

CI Agent Failure Analysis

Link to invocation

ziyixiong-nv · 2026-06-25T08:24:51Z

/bot run

tensorrt-cicd · 2026-06-25T08:30:49Z

PR_Github #55748 [ run ] triggered by Bot. Commit: 19f9710 Link to invocation

tensorrt-cicd · 2026-06-25T09:27:26Z

PR_Github #55748 [ run ] completed with state SUCCESS. Commit: 19f9710
/LLM/main/L0_MergeRequest_PR pipeline #44647 completed with status: 'FAILURE'

CI Report

⚠️ Action Required:

Please check the failed tests and fix your PR
If you cannot view the failures, ask the CI triggerer to share details
Once fixed, request an NVIDIA team member to trigger CI again

CI Agent Failure Analysis

Link to invocation

ziyixiong-nv · 2026-06-25T13:28:04Z

/bot run

tensorrt-cicd · 2026-06-25T13:34:35Z

PR_Github #55792 [ run ] triggered by Bot. Commit: 19f9710 Link to invocation

tensorrt-cicd · 2026-06-25T14:14:08Z

PR_Github #55792 [ run ] completed with state SUCCESS. Commit: 19f9710
/LLM/main/L0_MergeRequest_PR pipeline #44687 completed with status: 'FAILURE'

CI Report

⚠️ Action Required:

Please check the failed tests and fix your PR
If you cannot view the failures, ask the CI triggerer to share details
Once fixed, request an NVIDIA team member to trigger CI again

CI Agent Failure Analysis

Link to invocation

ziyixiong-nv · 2026-06-25T15:42:17Z

/bot run

tensorrt-cicd · 2026-06-25T15:48:21Z

PR_Github #55816 [ run ] triggered by Bot. Commit: 19f9710 Link to invocation

tensorrt-cicd · 2026-06-25T16:34:59Z

PR_Github #55816 [ run ] completed with state SUCCESS. Commit: 19f9710
/LLM/main/L0_MergeRequest_PR pipeline #44710 completed with status: 'FAILURE'

CI Report

⚠️ Action Required:

Please check the failed tests and fix your PR
If you cannot view the failures, ask the CI triggerer to share details
Once fixed, request an NVIDIA team member to trigger CI again

CI Agent Failure Analysis

Link to invocation

ziyixiong-nv · 2026-06-25T23:55:18Z

/bot run

tensorrt-cicd · 2026-06-26T00:00:59Z

PR_Github #55916 [ run ] triggered by Bot. Commit: 19f9710 Link to invocation

tensorrt-cicd · 2026-06-26T00:29:55Z

PR_Github #55916 [ run ] completed with state FAILURE. Commit: 19f9710
/LLM/main/L0_MergeRequest_PR pipeline #44799 completed with status: 'FAILURE'

CI Report

⚠️ Action Required:

Please check the failed tests and fix your PR
If you cannot view the failures, ask the CI triggerer to share details
Once fixed, request an NVIDIA team member to trigger CI again

CI Agent Failure Analysis

Link to invocation

Signed-off-by: ziyixiong-nv <219238287+ziyixiong-nv@users.noreply.github.com>

The pattern was missing the visual_gen/ directory segment, so the LFS filter never applied to the actual files under tests/integration/defs/examples/visual_gen/golden/visual_gen_lpips/. This caused git check-attr to return "unspecified", letting plain binary blobs be committed instead of LFS pointers. Signed-off-by: ziyixiong-nv <219238287+ziyixiong-nv@users.noreply.github.com>

ziyixiong-nv · 2026-06-26T00:36:49Z

/bot run --disable-fail-fast

tensorrt-cicd · 2026-06-26T00:43:03Z

PR_Github #55920 [ run ] triggered by Bot. Commit: 80ad48e Link to invocation

tensorrt-cicd · 2026-06-26T04:32:52Z

PR_Github #55920 [ run ] completed with state FAILURE. Commit: 80ad48e
/LLM/main/L0_MergeRequest_PR pipeline #44803 completed with status: 'FAILURE'

CI Report

⚠️ Action Required:

Please check the failed tests and fix your PR
If you cannot view the failures, ask the CI triggerer to share details
Once fixed, request an NVIDIA team member to trigger CI again

CI Agent Failure Analysis

Link to invocation

github-actions Bot assigned ziyixiong-nv Jun 25, 2026

ziyixiong-nv mentioned this pull request Jun 25, 2026

[https://nvbugs/6156233][fix] Lower GSM8K reference for the three GPT-OSS/20B-MXFP4 entries with… #15393

Merged

2 tasks

ziyixiong-nv changed the title ~~[None][chore] Remove redundant file~~ [None][chore] Update .gitattributes Jun 25, 2026

ziyixiong-nv requested a review from yibinl-nvidia June 25, 2026 02:35

yibinl-nvidia approved these changes Jun 25, 2026

View reviewed changes

ziyixiong-nv added 2 commits June 26, 2026 08:36

[None][chore] Remove redundant file

4f7e631

Signed-off-by: ziyixiong-nv <219238287+ziyixiong-nv@users.noreply.github.com>

ziyixiong-nv force-pushed the dev-fxiong-rm-file branch from 19f9710 to 80ad48e Compare June 26, 2026 00:36

Uh oh!

Conversation

ziyixiong-nv commented Jun 25, 2026 • edited by coderabbitai Bot Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Summary by CodeRabbit

Description

Test Coverage

PR Checklist

GitHub Bot Help

Uh oh!

ziyixiong-nv commented Jun 25, 2026

Uh oh!

tensorrt-cicd commented Jun 25, 2026

Uh oh!

ziyixiong-nv commented Jun 25, 2026

Uh oh!

coderabbitai Bot commented Jun 25, 2026

Walkthrough

Changes

Estimated code review effort

❌ Failed checks (1 warning)

Uh oh!

tensorrt-cicd commented Jun 25, 2026

Uh oh!

tensorrt-cicd commented Jun 25, 2026

Uh oh!

ziyixiong-nv commented Jun 25, 2026

Uh oh!

tensorrt-cicd commented Jun 25, 2026

Uh oh!

tensorrt-cicd commented Jun 25, 2026

Uh oh!

ziyixiong-nv commented Jun 25, 2026

Uh oh!

tensorrt-cicd commented Jun 25, 2026

Uh oh!

tensorrt-cicd commented Jun 25, 2026

Uh oh!

tensorrt-cicd commented Jun 25, 2026

Uh oh!

ziyixiong-nv commented Jun 25, 2026

Uh oh!

tensorrt-cicd commented Jun 25, 2026

Uh oh!

tensorrt-cicd commented Jun 25, 2026

Uh oh!

ziyixiong-nv commented Jun 25, 2026

Uh oh!

tensorrt-cicd commented Jun 25, 2026

Uh oh!

tensorrt-cicd commented Jun 25, 2026

Uh oh!

ziyixiong-nv commented Jun 25, 2026

Uh oh!

tensorrt-cicd commented Jun 25, 2026

Uh oh!

tensorrt-cicd commented Jun 25, 2026

Uh oh!

ziyixiong-nv commented Jun 25, 2026

Uh oh!

tensorrt-cicd commented Jun 25, 2026

Uh oh!

tensorrt-cicd commented Jun 25, 2026

Uh oh!

ziyixiong-nv commented Jun 25, 2026

Uh oh!

tensorrt-cicd commented Jun 26, 2026

Uh oh!

tensorrt-cicd commented Jun 26, 2026

Uh oh!

ziyixiong-nv commented Jun 26, 2026

Uh oh!

tensorrt-cicd commented Jun 26, 2026

Uh oh!

tensorrt-cicd commented Jun 26, 2026

Uh oh!

Reviewers

Assignees

Labels

Projects

ziyixiong-nv commented Jun 25, 2026 •

edited by coderabbitai Bot

Loading