fix(scan): exclude inactive Git hook samples - #412
Open
kriptoburak wants to merge 1 commit into
Open
Conversation
Signed-off-by: kriptoburak <kriptoburak@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
.git/hooks/*.sampletemplates as VCS metadata.git/configand active hook files in the bounded scan scopeProblem
A fresh
git initcreates executable sample hooks. SkillSpector inventoried all 14 templates as hidden artifacts, emitted anSC9HIGH finding for each, and rated an otherwise safe one-file skill as risk 56 withDO_NOT_INSTALL.The templates are not active while they retain the
.samplesuffix. They also come from the local Git installation rather than the scanned repository. Active hooks such as.git/hooks/pre-commitstill enter the scan.Validation
make lintmake format-checkgit diff --checkThe minimal safe Git skill now reports 0 findings and
SAFE. A remote scan ofXquik-dev/x-twitter-scraperremoves the 14 clone-generated sample-hook findings while retaining 100% component coverage and all repository-owned findings.Fixes #411