feat(provider): add MiniMax regional support - #366
Conversation
Signed-off-by: octo-patch <266937838+octo-patch@users.noreply.github.com>
| class MiniMaxProvider: | ||
| """MiniMax credentials, regional routing, and bundled model metadata.""" | ||
|
|
||
| DEFAULT_MODEL = "MiniMax-M3" |
There was a problem hiding this comment.
Official MiniMax API docs currently list MiniMax-M2.7 / MiniMax-M2.7-highspeed as the supported OpenAI-compatible model IDs, and the /v1/models example does not include MiniMax-M3; this default would make every out-of-box request fail. Use a served model with documented limits (or provide authoritative endpoint evidence plus a live contract test). Source: https://platform.minimax.io/docs/api-reference/api-overview
rng1995
left a comment
There was a problem hiding this comment.
[SkillSpector Review]
Requesting changes. The provider defaults to MiniMax-M3 with a 1M registry window, but current official MiniMax OpenAI-compatible docs list M2.7-family served IDs and a 204,800 combined context; the proposed default would fail out of the box. Use a documented served model/limits or provide authoritative endpoint evidence plus a live contract test. The branch also conflicts with main and DCO fails. See the inline source link.
Reason: Add a first-class MiniMax provider with current models and regional endpoint selection.
This change:
MiniMax-M3andMiniMax-M2.7with their current context windowsMINIMAX_REGION, with an explicit URL override availableChecks:
uv run pytest -q tests/unit/test_providers.py tests/unit/test_minimax_provider.pyuv run pytest -q tests/unit/test_agent_cli.pyuv run ruff check src/skillspector/providers/minimax tests/unit/test_minimax_provider.py src/skillspector/providers/__init__.py src/skillspector/providers/_agent_cli.py src/skillspector/cli.pyuv run ruff format --check src/skillspector/providers/minimax tests/unit/test_minimax_provider.py src/skillspector/providers/__init__.py src/skillspector/providers/_agent_cli.py src/skillspector/cli.pyuv run mypy src/skillspector/providers/minimaxuv run python -m build