Skip to content

fix(podman): deliver sandbox JWTs as secrets#2156

Merged
maxamillion merged 1 commit into
NVIDIA:mainfrom
maxamillion:podman_jwt_secrets
Jul 6, 2026
Merged

fix(podman): deliver sandbox JWTs as secrets#2156
maxamillion merged 1 commit into
NVIDIA:mainfrom
maxamillion:podman_jwt_secrets

Conversation

@maxamillion

@maxamillion maxamillion commented Jul 6, 2026

Copy link
Copy Markdown
Collaborator

Summary

Deliver Podman sandbox JWTs through per-sandbox Podman secrets instead of host bind-mounted token files. This keeps bearer tokens out of host state files while preserving the supervisor's file-based token loading path.

Related Issue

Issue: #1909
PR: #2111

Changes

  • Added Podman libpod secret create/delete client helpers.
  • Create a per-sandbox JWT secret during Podman sandbox provisioning and clean it up on failures/deletion.
  • Mount the JWT secret at the existing sandbox token file path and keep raw token values out of container env metadata.
  • Updated Podman driver documentation to describe JWT secret delivery.

Testing

  • mise run pre-commit passes
  • Unit tests added/updated
  • E2E tests added/updated (if applicable)

Additional validation:

  • cargo test -p openshell-driver-podman
  • Live local Podman API smoke checked secret create/delete and file-mounted secret readability.

Checklist

  • Follows Conventional Commits
  • Commits are signed off (DCO)
  • Architecture docs updated (if applicable)

Signed-off-by: Adam Miller <admiller@redhat.com>
@maxamillion maxamillion requested review from a team, derekwaynecarr and mrunalp as code owners July 6, 2026 22:26
@copy-pr-bot

copy-pr-bot Bot commented Jul 6, 2026

Copy link
Copy Markdown

This pull request requires additional validation before any workflows can run on NVIDIA's runners.

Pull request vetters can view their responsibilities here.

Contributors can view more details about this message here.

@TaylorMutch

Copy link
Copy Markdown
Collaborator

/ok to test 6b45b14

@maxamillion maxamillion merged commit abe42fb into NVIDIA:main Jul 6, 2026
32 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants