fix(python): raise SandboxError instead of FileNotFoundError or KeyError#1547
Open
mesutoezdil wants to merge 2 commits into
Open
fix(python): raise SandboxError instead of FileNotFoundError or KeyError#1547mesutoezdil wants to merge 2 commits into
mesutoezdil wants to merge 2 commits into
Conversation
mesutoezdil
requested review from
a team,
derekwaynecarr,
maxamillion and
mrunalp
as code owners
johntmyers
previously approved these changes
May 23, 2026
Collaborator
|
/ok to test 68a2b53 |
Collaborator
|
@mesutoezdil please address the failing checks. you should be able to run these checks on your local branches before opening PRs. |
Add `from None` to both `raise SandboxError(...)` calls inside `except FileNotFoundError` blocks to satisfy ruff B904.
Contributor
Author
Sorry for missing that. Ran mise run python:lint locally and caught the two B904 violations. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
_resolve_active_cluster: wrapsread_text()in atry/except FileNotFoundErrorso a missing active gateway file raisesSandboxErrorwith a clear message instead of a raw Python exceptionfrom_active_cluster: same fix formetadata.jsonnot found, plus an explicit check for the missinggateway_endpointkeyAll other error paths in the file already raise
SandboxError.These 2 were inconsistent.