fix(policy): allow uv in pypi preset#4569
Conversation
Signed-off-by: Carlos Villela <cvillela@nvidia.com>
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Path: .coderabbit.yaml Review profile: CHILL Plan: Enterprise Run ID: 📒 Files selected for processing (1)
📝 WalkthroughWalkthroughThe PyPI preset policy configuration is updated to include ChangesPyPI Preset Configuration
Estimated code review effort🎯 1 (Trivial) | ⏱️ ~2 minutes Poem
🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing Touches🧪 Generate unit tests (beta)
Comment |
E2E Advisor RecommendationRequired E2E: Dispatch hint: Auto-dispatched E2E: Full advisor summaryE2E Recommendation AdvisorBase: Required E2E
Optional E2E
New E2E recommendations
Dispatch hint
|
PR Review AdvisorFindings: 0 needs attention, 2 worth checking, 0 nice ideas Review findings🛠️ Needs attention
🔎 Worth checking
🌱 Nice ideas
This is an automated advisory review. A human maintainer must make the final merge decision. |
E2E Scenario Advisor RecommendationRequired scenario E2E: Dispatch required scenario E2E:
Full scenario advisor summaryE2E Scenario AdvisorBase: Required scenario E2E
Optional scenario E2E
Relevant changed files
|
Selective E2E Results — ✅ All requested jobs passedRun: 26691654469
|
Selective E2E Results — ✅ All requested jobs passedRun: 26691740044
|
Summary
Adds
/usr/local/bin/uvto the PyPI network preset binary allowlist so sandboxes using thepypipreset can run theuvpackage manager directly. This is a clean signed-off replacement for the blocked contributor PR #3368, whose code change was sound but whose branch cannot pass DCO without rewriting existing commits.Related Issue
Supersedes #3368.
Changes
nemoclaw-blueprint/policies/presets/pypi.yamlto allow/usr/local/bin/uvalongside the existing Python and pip binaries.Type of Change
Verification
npx prek run --all-filespassesnpm testpassesnpm run docsbuilds without warnings (doc changes only)Targeted validation run:
npm test -- test/policies.test.ts test/policy-tiers.test.ts test/validate-blueprint.test.ts. The relevant policy YAML checks passed, whiletest/policies.test.tscurrently has unrelated failures on currentorigin/mainaround missing policy helper exports and openshell resolution behavior.Signed-off-by: Carlos Villela cvillela@nvidia.com
Summary by CodeRabbit