feat: layer code-driven plugin config#199
Draft
zhongxuanwang-nv wants to merge 5 commits into
Draft
Conversation
Signed-off-by: Zhongxuan Wang <daniewang@nvidia.com>
|
Important Review skippedDraft detected. Please check the settings in the CodeRabbit UI or the ⚙️ Run configurationConfiguration used: Path: .coderabbit.yaml Review profile: ASSERTIVE Plan: Enterprise Run ID: You can disable this status message by setting the Use the checkbox below for a quick retry:
✨ Finishing Touches🧪 Generate unit tests (beta)
Comment |
Signed-off-by: Zhongxuan Wang <daniewang@nvidia.com>
Signed-off-by: Zhongxuan Wang <daniewang@nvidia.com>
Signed-off-by: Zhongxuan Wang <daniewang@nvidia.com>
Signed-off-by: Zhongxuan Wang <daniewang@nvidia.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Overview
Layers code-driven plugin configuration over materialized file-backed plugin configuration so callers can combine discovered
plugins.toml, inline[plugins].config, CLI overrides, request headers, and binding-level config builders deterministically.Details
layer_plugin_configto the Rust core plugin API with recursive object merging, scalar/array replacement, and top-level component upsert bykind.--plugin-configand request header config overlay the effective base.Quick functional check:
Expected output:
{ "version": 1, "components": [ { "kind": "observability", "enabled": False, "config": { "atof": { "enabled": True, "filename": "base.jsonl", "mode": "overwrite", } }, } ], }Validation: full Rust, Python, Node.js, Go, WebAssembly, docs,
cargo fmt,cargo clippy --workspace --all-targets -- -D warnings, anduv run pre-commit run --all-filespassed. Focused reruns covered core layering, CLI layer precedence, the realnemo-relay run --dry-runbinary path, and the Python/Node.js/Go/FFI/WebAssembly wrapper paths.Where should the reviewer start?
Start with
crates/core/src/plugin.rsfor the shared layering semantics, thencrates/cli/src/config.rsfor source precedence and CLI/header composition.Related Issues: (use one of the action keywords Closes / Fixes / Resolves / Relates to)