Skip to content

Comments

Remove test_llama_eval_sparse_attention#914

Merged
kevalmorabia97 merged 1 commit intomainfrom
kaix/sa_fix
Feb 21, 2026
Merged

Remove test_llama_eval_sparse_attention#914
kevalmorabia97 merged 1 commit intomainfrom
kaix/sa_fix

Conversation

@kaix-nv
Copy link
Contributor

@kaix-nv kaix-nv commented Feb 21, 2026

What does this PR do?

Type of change: ?
Bug fix

Overview: ?
Fix the example test.

Usage

# Add a code snippet demonstrating how to use this

Testing

Before your PR is "Ready for review"

  • Make sure you read and follow Contributor guidelines and your commits are signed.
  • Is this change backward compatible?: Yes/No
  • Did you write any new necessary tests?: Yes/No
  • Did you add or update any necessary documentation?: Yes/No
  • Did you update Changelog?: Yes/No

Additional Information

Summary by CodeRabbit

  • Tests
    • Removed a sparse attention test variant to streamline test coverage.

Signed-off-by: Kai Xu <kaix@nvidia.com>
@kaix-nv kaix-nv self-assigned this Feb 21, 2026
@coderabbitai
Copy link
Contributor

coderabbitai bot commented Feb 21, 2026

📝 Walkthrough

Walkthrough

A test function test_llama_eval_sparse_attention was removed from the test suite, eliminating a sparse attention test path that previously invoked run_llm_ptq_command with specific quantization and sparse configuration parameters.

Changes

Cohort / File(s) Summary
Test Function Removal
tests/examples/llm_eval/test_llm_eval.py
Removed the test_llama_eval_sparse_attention test function and associated sparse attention test logic, including cleanup for llm-serve.

Estimated code review effort

🎯 1 (Trivial) | ⏱️ ~3 minutes

🚥 Pre-merge checks | ✅ 3
✅ Passed checks (3 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Title check ✅ Passed The title 'Remove test_llama_eval_sparse_attention' directly and specifically describes the main change: removal of a test function. It is concise, clear, and accurately reflects the changeset.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.

✨ Finishing Touches
  • 📝 Generate docstrings (stacked PR)
  • 📝 Generate docstrings (commit on current branch)
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Post copyable unit tests in a comment
  • Commit unit tests in branch kaix/sa_fix

Tip

Issue Planner is now in beta. Read the docs and try it out! Share your feedback on Discord.


Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@kevalmorabia97 kevalmorabia97 changed the title Fix the example test Remove test_llama_eval_sparse_attention Feb 21, 2026
@codecov
Copy link

codecov bot commented Feb 21, 2026

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 73.11%. Comparing base (9e23c6c) to head (607fade).
⚠️ Report is 1 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #914      +/-   ##
==========================================
+ Coverage   73.10%   73.11%   +0.01%     
==========================================
  Files         205      205              
  Lines       22281    22281              
==========================================
+ Hits        16288    16291       +3     
+ Misses       5993     5990       -3     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@kevalmorabia97 kevalmorabia97 merged commit 70ffb6f into main Feb 21, 2026
37 checks passed
@kevalmorabia97 kevalmorabia97 deleted the kaix/sa_fix branch February 21, 2026 09:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants