Skip to content

Unified diffusion model trainer#1082

Draft
mxinO wants to merge 25 commits intomainfrom
mxin/ltx-distill-v2
Draft

Unified diffusion model trainer#1082
mxinO wants to merge 25 commits intomainfrom
mxin/ltx-distill-v2

Conversation

@mxinO
Copy link
Copy Markdown
Contributor

@mxinO mxinO commented Mar 20, 2026

What does this PR do?

Type of change: new feature

Usage

For diffusion model distillation or finetuning. Support Wan2.2 models and LTX2 models. See readme.md for more details.

Testing

Tested with mock data

Before your PR is "Ready for review"

Make sure you read and follow Contributor guidelines and your commits are signed (git commit -s -S).

Make sure you read and follow the Security Best Practices (e.g. avoiding hardcoded trust_remote_code=True, torch.load(..., weights_only=False), pickle, etc.).

  • Is this change backward compatible?: ❌
    It will replace the old ltx2 trainer.
  • If you copied code from any other sources or added a new PIP dependency, did you follow guidance in CONTRIBUTING.md: N/A
  • Did you write any new necessary tests?: ❌
  • Did you update Changelog?: ✅

Additional Information

mxinO added 17 commits February 13, 2026 17:37
Signed-off-by: Meng Xin <mxin@nvidia.com>
Signed-off-by: Meng Xin <mxin@nvidia.com>
Signed-off-by: Meng Xin <mxin@nvidia.com>
Signed-off-by: Meng Xin <mxin@nvidia.com>
Signed-off-by: Meng Xin <mxin@nvidia.com>
Signed-off-by: Meng Xin <mxin@nvidia.com>
Signed-off-by: Meng Xin <mxin@nvidia.com>
Signed-off-by: Meng Xin <mxin@nvidia.com>
Signed-off-by: Meng Xin <mxin@nvidia.com>
Signed-off-by: Meng Xin <mxin@nvidia.com>
Signed-off-by: Meng Xin <mxin@nvidia.com>
Signed-off-by: Meng Xin <mxin@nvidia.com>
Signed-off-by: Meng Xin <mxin@nvidia.com>
Signed-off-by: Meng Xin <mxin@nvidia.com>
Signed-off-by: Meng Xin <mxin@nvidia.com>
@copy-pr-bot
Copy link
Copy Markdown

copy-pr-bot Bot commented Mar 20, 2026

Auto-sync is disabled for draft pull requests in this repository. Workflows must be run manually.

Contributors can view more details about this message here.

@coderabbitai
Copy link
Copy Markdown
Contributor

coderabbitai Bot commented Mar 20, 2026

Important

Review skipped

Draft detected.

Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

⚙️ Run configuration

Configuration used: Path: .coderabbit.yaml

Review profile: CHILL

Plan: Enterprise

Run ID: 586b78ed-1c29-406b-96dd-0ce8baa5517f

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Use the checkbox below for a quick retry:

  • 🔍 Trigger review
✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch mxin/ltx-distill-v2

Comment @coderabbitai help to get the list of available commands and usage tips.

Signed-off-by: Meng Xin <mxin@nvidia.com>
@mxinO mxinO changed the title Unified diffuser trainer Unified diffusion model trainer Mar 20, 2026
Signed-off-by: Meng Xin <mxin@nvidia.com>
@codecov
Copy link
Copy Markdown

codecov Bot commented Mar 20, 2026

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 52.52%. Comparing base (ade9567) to head (65efa55).
⚠️ Report is 1 commits behind head on main.

Additional details and impacted files
@@             Coverage Diff             @@
##             main    #1082       +/-   ##
===========================================
- Coverage   75.72%   52.52%   -23.20%     
===========================================
  Files         476      475        -1     
  Lines       51068    51238      +170     
===========================================
- Hits        38670    26914    -11756     
- Misses      12398    24324    +11926     
Flag Coverage Δ
examples ?
gpu ?
regression ?
unit 52.52% <ø> (+0.20%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

mxinO added 4 commits March 20, 2026 02:31
Signed-off-by: Meng Xin <mxin@nvidia.com>
Signed-off-by: Meng Xin <mxin@nvidia.com>
Signed-off-by: Meng Xin <mxin@nvidia.com>
Signed-off-by: Meng Xin <mxin@nvidia.com>
@jingyu-ml jingyu-ml requested review from jingyu-ml and ynankani April 1, 2026 07:48
@github-actions
Copy link
Copy Markdown
Contributor

github-actions Bot commented Apr 3, 2026

PR Preview Action v1.8.1

QR code for preview link

🚀 View preview at
https://NVIDIA.github.io/Model-Optimizer/pr-preview/pr-1082/

Built to branch gh-pages at 2026-04-03 22:03 UTC.
Preview will be ready when the GitHub Pages deployment is complete.

Signed-off-by: Jingyu Xin <jingyux@nvidia.com>
@copy-pr-bot
Copy link
Copy Markdown

copy-pr-bot Bot commented May 6, 2026

This pull request requires additional validation before any workflows can run on NVIDIA's runners.

Pull request vetters can view their responsibilities here.

Contributors can view more details about this message here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants