README: enhance build instructions#6047
Conversation
de22883 to
e51dac9
Compare
e51dac9 to
65227bc
Compare
* Add much more information about installing build dependencies. * Fix the verification command to use the actual Python module name, so that verification succeeds.
65227bc to
ce94b1f
Compare
kevinstephano
left a comment
There was a problem hiding this comment.
Looks good to me.
|
!build |
|
It looks like the nvfuser-ci job failed/hung. |
|
I added some more notes re: running tests, since the CI failed for the previous push anyway. Even if CI continues to fail, at least these notes will be recorded in this PR, so people may be able to find them:-) |
| thunder \ | ||
| transformers \ | ||
| pip install \ | ||
| --no-build-isolation transformer_engine[pytorch] |
There was a problem hiding this comment.
The trailing backslash on the
transformers line causes shell line continuation, so the second pip install and its arguments are concatenated onto the first command. The shell sees one long command: pip install apache-tvm-ffi ... transformers pip install --no-build-isolation transformer_engine[pytorch], which passes the literal strings pip, install, and --no-build-isolation as package names — the transformer_engine installation never runs as a separate command.
| thunder \ | |
| transformers \ | |
| pip install \ | |
| --no-build-isolation transformer_engine[pytorch] | |
| thunder \ | |
| transformers | |
| pip install \ | |
| --no-build-isolation transformer_engine[pytorch] |
e159cca to
19538fb
Compare
|
!test |
so that verification succeeds.