Skip to content

Document that the dali-dynamic-mode skill exists#6358

Open
rostan-t wants to merge 4 commits into
NVIDIA:mainfrom
rostan-t:ndd-skill-doc
Open

Document that the dali-dynamic-mode skill exists#6358
rostan-t wants to merge 4 commits into
NVIDIA:mainfrom
rostan-t:ndd-skill-doc

Conversation

@rostan-t
Copy link
Copy Markdown
Collaborator

@rostan-t rostan-t commented May 20, 2026

Category:

Other (e.g. Documentation, Tests, Configuration)

Description:

Point to the dali-dynamic-mode skill in NVIDIA/skills in the documentation.

Additional information:

Affected modules and functionalities:

Dynamic API Overview documentation page:
Capture d’écran 2026-05-20 à 14 25 46

Key points relevant for the review:

Tests:

  • Existing tests apply
  • New tests added
    • Python tests
    • GTests
    • Benchmark
    • Other
  • N/A

Checklist

Documentation

  • Existing documentation applies
  • Documentation updated
    • Docstring
    • Doxygen
    • RST
    • Jupyter
    • Other
  • N/A

DALI team only

Requirements

  • Implements new requirements
  • Affects existing requirements
  • N/A

REQ IDs: N/A

JIRA TASK: N/A

@greptile-apps
Copy link
Copy Markdown
Contributor

greptile-apps Bot commented May 20, 2026

Greptile Summary

This PR adds documentation pointing users to the dali-dynamic-mode skill in the NVIDIA/skills repository, giving AI agents a reference for the Dynamic Mode API.

  • Adds a .. tip:: admonition to docs/dali_dynamic/overview.rst with the skill link and npx skills add install command.
  • Adds a GitHub-only [!TIP] pull-quote to README.rst (rendered as a GitHub admonition, hidden in Sphinx HTML via injected CSS), and promotes the "DALI in action" paragraph to a proper RST section heading.

Confidence Score: 5/5

Pure documentation change with no code or logic modifications — safe to merge.

Both changed files are RST documentation only. The dual-rendering trick (CSS-hidden pull-quote for GitHub, native .. tip:: for Sphinx) is self-contained and correctly implemented. No executable code, APIs, or data paths are touched.

No files require special attention.

Important Files Changed

Filename Overview
docs/dali_dynamic/overview.rst Adds a .. tip:: admonition documenting the dali-dynamic-mode skill with install instructions; RST syntax is correct and placement is logical.
README.rst Inserts a GitHub-only [!TIP] pull-quote for the skill (hidden in Sphinx via injected CSS) and promotes "DALI in action" to a proper section heading; mechanism is sound.

Flowchart

%%{init: {'theme': 'neutral'}}%%
flowchart TD
    A[README.rst and overview.rst] --> B{Rendering context}
    B -->|GitHub RST preview| C[pull-quote renders as blockquote - GH admonition visible]
    B -->|Sphinx HTML| D[CSS injected - pull-quote hidden via github-only class]
    B -->|Sphinx HTML| E[tip directive in overview.rst renders as native tip box]
Loading

Reviews (11): Last reviewed commit: "Fix broken links to skill" | Re-trigger Greptile

Comment thread docs/dali_dynamic/overview.rst Outdated
@rostan-t
Copy link
Copy Markdown
Collaborator Author

!build

@dali-automaton
Copy link
Copy Markdown
Collaborator

CI MESSAGE: [51951217]: BUILD STARTED

@JanuszL JanuszL self-assigned this May 20, 2026
@dali-automaton
Copy link
Copy Markdown
Collaborator

CI MESSAGE: [51951217]: BUILD PASSED

@JanuszL
Copy link
Copy Markdown
Contributor

JanuszL commented May 21, 2026

@rostan-t - how about adding this note also to the readme, maybe just above the examples and after the about section?

@rostan-t rostan-t force-pushed the ndd-skill-doc branch 7 times, most recently from 6ef9c45 to efbc486 Compare May 26, 2026 15:36
@rostan-t
Copy link
Copy Markdown
Collaborator Author

@rostan-t - how about adding this note also to the readme, maybe just above the examples and after the about section?

What about efbc486? GitHub's RST renderer doesn't handle admonition so I workaround it to show a collapsible on GitHub instead and a proper .. tip in the documentation.

@rostan-t
Copy link
Copy Markdown
Collaborator Author

!build

@dali-automaton
Copy link
Copy Markdown
Collaborator

CI MESSAGE: [52661253]: BUILD STARTED

@dali-automaton
Copy link
Copy Markdown
Collaborator

CI MESSAGE: [52661253]: BUILD PASSED

rostan-t added 3 commits June 2, 2026 07:29
Signed-off-by: Rostan Tabet <rtabet@nvidia.com>
Signed-off-by: Rostan Tabet <rtabet@nvidia.com>
Signed-off-by: Rostan Tabet <rtabet@nvidia.com>
@rostan-t
Copy link
Copy Markdown
Collaborator Author

rostan-t commented Jun 2, 2026

!build

@dali-automaton
Copy link
Copy Markdown
Collaborator

CI MESSAGE: [53388427]: BUILD STARTED

Signed-off-by: Rostan Tabet <rtabet@nvidia.com>
@rostan-t
Copy link
Copy Markdown
Collaborator Author

rostan-t commented Jun 2, 2026

!build

@dali-automaton
Copy link
Copy Markdown
Collaborator

CI MESSAGE: [53389553]: BUILD STARTED

@dali-automaton
Copy link
Copy Markdown
Collaborator

CI MESSAGE: [53389553]: BUILD FAILED

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants