feat(plugin): Decouple nemo-platform-plugin from nmp-common#145
Draft
matthewgrossman wants to merge 8 commits into
Draft
feat(plugin): Decouple nemo-platform-plugin from nmp-common#145matthewgrossman wants to merge 8 commits into
matthewgrossman wants to merge 8 commits into
Conversation
Signed-off-by: Matthew Grossman <mgrossman@nvidia.com>
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
| return _extract_validated_fields(validated, raw) | ||
|
|
||
| return _dep | ||
| from nemo_platform_plugin.api.filters import make_filter_obj_dep as make_filter_obj_dep |
Contributor
Author
There was a problem hiding this comment.
False positive — this is an intentional backward-compat re-export using the import X as X pattern so existing consumers of nmp.common continue to work.
| return f"{effective_registry}/{name}:{effective_tag}" | ||
|
|
||
| return _build | ||
| from nemo_platform_plugin.config import get_qualified_image as get_qualified_image |
Contributor
Author
There was a problem hiding this comment.
False positive — this is an intentional backward-compat re-export using the import X as X pattern so existing consumers of nmp.common continue to work.
|
|
||
| return _build | ||
| from nemo_platform_plugin.config import get_qualified_image as get_qualified_image | ||
| from nemo_platform_plugin.config import image_builder as image_builder |
Contributor
Author
There was a problem hiding this comment.
False positive — this is an intentional backward-compat re-export using the import X as X pattern so existing consumers of nmp.common continue to work.
Contributor
|
- Remove redundant `...` from Protocol methods (docstrings suffice) - Replace global variables with dict-based state to avoid false "unused global variable" warnings Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com> Signed-off-by: Matthew Grossman <mgrossman@nvidia.com>
matthewgrossman
commented
Jun 2, 2026
| return dict(sdk._custom_headers) | ||
|
|
||
|
|
||
| __all__ = [ |
Contributor
Author
There was a problem hiding this comment.
why do we need this all?
matthewgrossman
commented
Jun 2, 2026
| # --------------------------------------------------------------------------- | ||
|
|
||
|
|
||
| class PlatformTaskSDKProvider: |
Contributor
Author
There was a problem hiding this comment.
more broadly: does this really need to be a TaskSdkProvider? why not just SDKProvider?
Signed-off-by: Matthew Grossman <mgrossman@nvidia.com>
…mgrossman Signed-off-by: Matthew Grossman <mgrossman@nvidia.com>
| # Fall back to the built-in default. | ||
| logger.debug("No entry-point task SDK provider found; using DefaultSDKProvider") | ||
| default = DefaultSDKProvider() | ||
| _provider = default |
| logger.debug("No entry-point task SDK provider found; using DefaultSDKProvider") | ||
| default = DefaultSDKProvider() | ||
| _provider = default | ||
| _resolved = True |
| obj = obj() | ||
| if isinstance(obj, SDKProvider): | ||
| logger.debug("Using SDK provider from entry-point %r", ep.name) | ||
| _provider = obj |
| if isinstance(obj, SDKProvider): | ||
| logger.debug("Using SDK provider from entry-point %r", ep.name) | ||
| _provider = obj | ||
| _resolved = True |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Decouples
nemo-platform-pluginfromnmp-commonso plugin authors only depend on the plugin package.SDKProviderprotocol +DefaultSDKProvider(env-var-based) innemo_platform_plugin.task_sdknmp-commonregisters a richerPlatformSDKProvidervia entry-point, discovered automatically when installedget_qualified_image,image_builder,make_filter_obj_dep,parse_entity_ref, and config classes into the plugin packagenmp.common; backward-compat re-exports remain for servicesnmp.commonimports in pluginsTest plan
SDKProviderprotocol, default provider, entry-point resolution, and provider overrideget_forwarding_headerspre-commit run --all-files --hook-stage pre-pushpassesSigned-off-by: Matthew Grossman mgrossman@nvidia.com
🤖 Generated with Claude Code