refactor(intake): add ClickHouse DAO layer for spans storage#115
Draft
asutermo wants to merge 8 commits into
Draft
refactor(intake): add ClickHouse DAO layer for spans storage#115asutermo wants to merge 8 commits into
asutermo wants to merge 8 commits into
Conversation
Introduce a parameterized query builder and base DAO so span repositories share consistent, injection-safe ClickHouse access patterns instead of ad hoc f-string SQL assembly. Signed-off-by: Andrew Suter-Morris <asutermorris@nvidia.com>
Contributor
|
Move filter construction into clickhouse/filters.py, hide the mutable builder behind an opaque WhereClause, and route trace rollup SQL through paginate_subquery so repositories no longer assemble raw predicates. Signed-off-by: Andrew Suter-Morris <asutermorris@nvidia.com>
Introduce BuiltQuery and TrustedSql so DAO execution only accepts rendered queries from trusted builders, closing raw SQL tuple escape hatches and whitelisting sort keys in fetch_all. Signed-off-by: Andrew Suter-Morris <asutermorris@nvidia.com>
Signed-off-by: Andrew Suter-Morris <asutermorris@nvidia.com>
…use DAO Bundle sort whitelists into SortSpec, detect conflicting bound parameters via merge_parameters, and route trace subquery counts through SelectQuery. Signed-off-by: Andrew Suter-Morris <asutermorris@nvidia.com>
Integrate experiment ClickHouse rollups (#154) with the DAO layer: experiment_queries module, fetch_rows on ClickHouseDao, and ExperimentRollupRepository using trusted BuiltQuery execution. Signed-off-by: Andrew Suter-Morris <asutermorris@nvidia.com>
Signed-off-by: Andrew Suter-Morris <asutermorris@nvidia.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Introduce a parameterized query builder and base DAO so span repositories share consistent, help introduce injection-safe ClickHouse access patterns instead of ad hoc f-string SQL assembly.