fix(translation): decode OpenRouter cache write usage#141
Merged
Conversation
Signed-off-by: nachiketb <nachiketb@nvidia.com>
ayushag-nv
marked this pull request as ready for review
July 24, 2026 23:51
ayushag-nv
approved these changes
Jul 24, 2026
|
Caution Review failedThe pull request is closed. ℹ️ Recent review info⚙️ Run configurationConfiguration used: Path: .coderabbit.yaml Review profile: CHILL Plan: Enterprise Run ID: 📒 Files selected for processing (4)
WalkthroughOpenAI Chat usage normalization now prefers ChangesOpenAI cache usage
Estimated code review effort: 2 (Simple) | ~10 minutes Poem
Comment |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
prompt_tokens_details.cache_write_tokensfield in buffered OpenAI Chat responsescache_creation_tokensas a compatibility aliasRoot cause
OpenRouter reports cache writes as
cache_write_tokens, while the OpenAI Chat codecs only recognizedcache_creation_tokens. Cache-write tokens were therefore left in the uncached input count and omitted from normalized cache-creation usage.Validation
cargo fmt --all -- --checkcargo test -p switchyard-translationcargo clippy -p switchyard-translation --all-targets -- -D warningsSummary by CodeRabbit
Bug Fixes
Tests