fix(translation): encode Responses tool turns correctly#111
Open
nachiketb-nvidia wants to merge 1 commit into
Open
fix(translation): encode Responses tool turns correctly#111nachiketb-nvidia wants to merge 1 commit into
nachiketb-nvidia wants to merge 1 commit into
Conversation
Signed-off-by: nachiketb <nachiketb@nvidia.com>
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Path: .coderabbit.yaml Review profile: CHILL Plan: Enterprise Run ID: 📒 Files selected for processing (2)
WalkthroughChangesResponses translation
Estimated code review effort: 3 (Moderate) | ~20 minutes Poem
🚥 Pre-merge checks | ✅ 4 | ❌ 1❌ Failed checks (1 warning)
✅ Passed checks (4 passed)
Comment |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
Fix OpenAI Responses request encoding for normalized tool turns.
function_call.argumentsas a JSON string, as required by the Responses API.Why
Anthropic tool-use input is represented as structured JSON in the neutral request type, while the
Responses API requires the same arguments to be serialized as a JSON string. Anthropic private
thinking also cannot be replayed as a Responses reasoning item.
Keeping this translation behavior in a focused MR avoids coupling provider codec correctness to the
libsy server refactor.
How
The Responses encoder serializes normalized tool-call arguments with the existing
json_stringhelper. It filters reasoning blocks carrying an Anthropic signature and continues to encode unsigned
reasoning blocks produced by the Responses decoder.
What to review
function_callinput.Validation
cargo fmt --all --checkcargo test -p switchyard-translation --test request_translation(34 passed)Summary by CodeRabbit