fix: set TIS type for Automodel GRPO release recipes#2544
Draft
zpqiu wants to merge 2 commits into
Draft
Conversation
Signed-off-by: Zhaopeng Qiu <alexq@nvidia.com>
Signed-off-by: Zhaopeng Qiu <alexq@nvidia.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this PR do ?
Fixes Automodel GRPO release recipes that can crash when
truncated_importance_sampling_ratiois configured without an explicittruncated_importance_sampling_type.The Qwen3.5 DAPO and GLM-4.7 Flash Automodel recipes already set
truncated_importance_sampling_ratio: 2, but did not set the corresponding sampling type. This PR setsloss_fn.truncated_importance_sampling_type: tisin both recipes so the ratio is interpreted through the intended TIS path.Additional release-test stabilization:
train/token_mult_prob_errorcheck.train/token_mult_prob_error, which has high tail variance.train/gen_kl_erroras the policy/generation mismatch check.Issues
N/A
Usage
No user-facing usage change. This updates release recipe/test configuration only.
Before your PR is "Ready for review"
Pre checks:
Additional Information
Validation performed:
bash -n tests/test_suites/llm/grpo-glm47-flash-4n8g-automodel.shtruncated_importance_sampling_type: tis.median(train/token_mult_prob_error) = 1.059859812259674 < 1.1mean(train/gen_kl_error) = 0.007180878799408675 < 0.01train/reward[30] = 0.666015625 > 0.3max(validation/accuracy) = 0.5291666388511658 > 0.2mean(train/grad_norm) = 0.15234075884024303 < 0.6train/token_mult_prob_error[30] < 1.1; the rerun observed17.038604736328125at step 30 while the median and KL checks remained healthy.