Skip to content

feat: make only_unmask_final configurable in SFT#2543

Open
ashors1 wants to merge 1 commit into
mainfrom
ashors/configure_unmask_final
Open

feat: make only_unmask_final configurable in SFT#2543
ashors1 wants to merge 1 commit into
mainfrom
ashors/configure_unmask_final

Conversation

@ashors1
Copy link
Copy Markdown
Contributor

@ashors1 ashors1 commented May 22, 2026

What does this PR do ?

Add a one line overview of what this PR aims to accomplish.

Issues

List issues that this PR closes (syntax):

Usage

  • You can potentially add a usage example below
# Add a code snippet demonstrating how to use this

Before your PR is "Ready for review"

Pre checks:

  • Make sure you read and followed Contributor guidelines
  • Did you write any new necessary tests?
  • Did you run the unit tests and functional tests locally? Visit our Testing Guide for how to run tests
  • Did you add or update any necessary documentation? Visit our Document Development Guide for how to write, build and test the docs.

Additional Information

  • ...

Signed-off-by: ashors1 <ashors@nvidia.com>
@ashors1 ashors1 requested review from a team as code owners May 22, 2026 03:01
@copy-pr-bot
Copy link
Copy Markdown

copy-pr-bot Bot commented May 22, 2026

This pull request requires additional validation before any workflows can run on NVIDIA's runners.

Pull request vetters can view their responsibilities here.

Contributors can view more details about this message here.

Copy link
Copy Markdown
Contributor

@yuki-97 yuki-97 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

hi @ashors1 , thanks for adding this.
it seems duplicated with #2516, do you mind reviewing #2516 and go with that?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants