feat: fix the vLLM DP path#2517
Open
guyueh1 wants to merge 22 commits into
Open
Conversation
Signed-off-by: Guyue Huang <guyueh@login-lyris01.lyris.clusters.nvidia.com>
Contributor
Author
|
/ok to test efc6fc2 |
added 2 commits
May 18, 2026 09:36
Signed-off-by: Guyue Huang <guyueh@login-lyris01.lyris.clusters.nvidia.com>
Contributor
Author
|
/ok to test 9f381f2 |
Contributor
Author
|
fast CI is failing for |
Contributor
Author
Contributor
Author
|
/ok to test d03ceee |
yuki-97
reviewed
May 25, 2026
Contributor
|
@terrykong could you help to take a review as well? |
Signed-off-by: Guyue Huang <guyueh@nvidia.com>
Signed-off-by: Guyue Huang <guyueh@nvidia.com>
Contributor
Author
|
/ok to test 2272d47 |
Signed-off-by: Guyue Huang <guyueh@nvidia.com>
Contributor
Author
|
/ok to test 0ea633c |
yuki-97
previously approved these changes
May 29, 2026
Contributor
Author
@terrykong please review |
Signed-off-by: Guyue Huang <140554423+guyueh1@users.noreply.github.com>
Contributor
Author
|
/ok to test 05db6ab |
Collaborator
|
Thanks @guyueh1 . I think there is some patching for fp8 (fp8.py) that patches the raydistributedexecutor. Does this mean that functionality is broken by this PR unless we fix? Or does mp backend natively solve this? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.

What does this PR do ?
Previously nemo-rl doesn't work for vllm's native DP (EP>TP), this PR wants to support this case.
The following basic tests have passed, now trying the nightly test
New nightly test figures:

H100 with EP=8 async engine
https://wandb.ai/nvidia/nemo-rl/runs/4mcplb63
H100 with TP=2 EP=16 sync engine

https://wandb.ai/nvidia/nemo-rl/runs/b3mon8zg
Issues
List issues that this PR closes (syntax):
Usage
# Add a code snippet demonstrating how to use thisBefore your PR is "Ready for review"
Pre checks:
Additional Information