fix: fix preserving dataset merge#2515
Merged
Merged
Conversation
Contributor
Author
|
/ok to test 8ad3cc6 |
yuki-97
added
the
CI:Lfast
Contributor
Author
|
/ok to test 8ad3cc6 |
Signed-off-by: Yuki Huang <yukih@nvidia.com>
Signed-off-by: Yuki Huang <yukih@nvidia.com>
Contributor
Author
|
/ok to test 4d376b7 |
terrykong
approved these changes
May 28, 2026
vigneshwaran
pushed a commit
to vigneshwaran/RL
that referenced
this pull request
May 28, 2026
Signed-off-by: Yuki Huang <yukih@nvidia.com> Co-authored-by: Youngmin Park <57158717+Bungmint@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Continues #2218, thanks for the contribution @Bungmint.
Issue
Closes #2116.
Summary
concatenate_datasetswith a newmerge_datasetshelper throughout the SFT data pipeline (run_sft.py,nemo_rl/data/utils.py).merge_datasetsfalls back totorch.utils.data.ConcatDatasetwhen any dataset is not a HFDataset(e.g.PreservingDataset), avoiding the schema validation crash fromconcatenate_datasets.Test plan
tests/unit/data/datasets/test_preserving_dataset.pypasses (new tests cover HF-only,PreservingDataset-only, and mixed merge cases).