fix(vllm): serialise AsyncMPClient input_socket sends to prevent zmq race#2513
Open
kaloyan-inherent wants to merge 3 commits into
Open
fix(vllm): serialise AsyncMPClient input_socket sends to prevent zmq race#2513kaloyan-inherent wants to merge 3 commits into
kaloyan-inherent wants to merge 3 commits into
Conversation
Signed-off-by: Kaloyan <253267049+kaloyan-inherent@users.noreply.github.com>
kaloyan-inherent
changed the title
svcnvidia-nemo-ci
added
the
waiting-on-maintainers
Collaborator
|
Thanks @kaloyan-inherent @yuki-97 @bxyu-nvidia @ananthsub @sharonyu-115 coudl you review? |
svcnvidia-nemo-ci
removed
the
waiting-on-maintainers
yuki-97
reviewed
May 21, 2026
Contributor
yuki-97
left a comment
yuki-97
left a comment
There was a problem hiding this comment.
@kaloyan-inherent thanks for the investigation and fix! overall LGTM, only some minor comments.
svcnvidia-nemo-ci
added
the
waiting-on-customer
Signed-off-by: Kaloyan <253267049+kaloyan-inherent@users.noreply.github.com>
Author
great thanks for the review -- addressed both comments |
svcnvidia-nemo-ci
removed
the
waiting-on-customer
yuki-97
added
the
CI:Lfast
Contributor
|
/ok to test b6035f6 |
yuki-97
approved these changes
May 22, 2026
Contributor
|
@bxyu-nvidia @ananthsub @sharonyu-115 could you help to take a review as well? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this PR do ?
This PR addresses issue #2512 ; It wraps _shadow_sock.send_multipart with a threading.Lock, which serialises access when the http server is exposed.
Issues
Closes #2512.