Skip to content

fix: convert_dcp_to_hf.py correctly loads saved tokenizer from DCP if detected#2210

Merged
yuki-97 merged 5 commits intomainfrom
degert/dcp-conversion-fix
Apr 15, 2026
Merged

fix: convert_dcp_to_hf.py correctly loads saved tokenizer from DCP if detected#2210
yuki-97 merged 5 commits intomainfrom
degert/dcp-conversion-fix

Conversation

@trias702
Copy link
Copy Markdown
Contributor

@trias702 trias702 commented Apr 3, 2026

What does this PR do ?

Fixed convert_dcp_to_hf.py to load the tokenizer directory when detected.

Usage

  • You can potentially add a usage example below
uv run python examples/converters/convert_dcp_to_hf.py --config /path/to/config.yaml --dcp-ckpt-path /path/to/policy/weights --hf-ckpt-path /path/to/hf

Before your PR is "Ready for review"

Pre checks:

  • Make sure you read and followed Contributor guidelines
  • Did you write any new necessary tests?
  • Did you run the unit tests and functional tests locally? Visit our Testing Guide for how to run tests
  • [] Did you add or update any necessary documentation? Visit our Document Development Guide for how to write, build and test the docs.

Additional Information

  • ...

…ted.

Signed-off-by: Daniel Egert <degert@nvidia.com>
@trias702 trias702 requested a review from a team as a code owner April 3, 2026 22:01
@copy-pr-bot
Copy link
Copy Markdown

copy-pr-bot bot commented Apr 3, 2026

This pull request requires additional validation before any workflows can run on NVIDIA's runners.

Pull request vetters can view their responsibilities here.

Contributors can view more details about this message here.

@trias702 trias702 requested a review from terrykong April 3, 2026 22:01
@yuki-97
Copy link
Copy Markdown
Contributor

yuki-97 commented Apr 8, 2026

@RayenTian could you help to take a review?

@yuki-97 yuki-97 requested a review from RayenTian April 8, 2026 03:41
@RayenTian
Copy link
Copy Markdown
Contributor

@trias702 Thanks a lot for adding this! lgtm!
CC: @yuki-97

Copy link
Copy Markdown
Contributor

@yuki-97 yuki-97 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

hi @trias702 , thanks for helping fix this! left some minor comments.

Comment thread examples/converters/convert_dcp_to_hf.py Outdated
Comment thread examples/converters/convert_dcp_to_hf.py Outdated
Signed-off-by: Daniel Egert <degert@nvidia.com>
@terrykong terrykong changed the title fix: convert_dcp_to_hf.py correctly loads the saved tokenizer from DCP if detected fix: convert_dcp_to_hf.py correctly loads saved tokenizer from DCP if detected Apr 13, 2026
@yuki-97 yuki-97 added the CI:Lfast Runs a fast test suite and re-use nightly `main` container (but sync dependencies to PRs version) label Apr 13, 2026
@yuki-97
Copy link
Copy Markdown
Contributor

yuki-97 commented Apr 13, 2026

/ok to test 698757c

yuki-97
yuki-97 previously approved these changes Apr 13, 2026
@yuki-97
Copy link
Copy Markdown
Contributor

yuki-97 commented Apr 13, 2026

hi @trias702 , there's a lint check fail, could you help to fix?

@trias702
Copy link
Copy Markdown
Contributor Author

hi @trias702 , there's a lint check fail, could you help to fix?

Sorry, I don't understand why it's failing. I'm afraid I don't know much about linting or how it works.

@RayenTian
Copy link
Copy Markdown
Contributor

RayenTian commented Apr 14, 2026

hi @trias702 , there's a lint check fail, could you help to fix?

Sorry, I don't understand why it's failing. I'm afraid I don't know much about linting or how it works.

Hi, @trias702. Lint check is a static code analysis tool that automatically scans your code for style issues, syntax problems, potential bugs, and violations of the project's coding standards.
You can refer to this doc to install pre-commit. Next time when you commit, the lint check will be triggered locally. Simply re-add the automatically fixed files and commit again. If any errors remain, the command output will show the specific files and rules that require manual adjustment.

Alternatively, if you prefer not to install pre-commit, you can run pre-commit run --all-files directly in the nemorl root workspace. This will also trigger the nemorl lint check and auto fix.

Feel free to let us know if you need help with any particular failure.

Signed-off-by: Daniel Egert <degert@nvidia.com>
@yuki-97
Copy link
Copy Markdown
Contributor

yuki-97 commented Apr 15, 2026

/ok to test 2382747

@yuki-97
Copy link
Copy Markdown
Contributor

yuki-97 commented Apr 15, 2026

/ok to test 00c1c10

@yuki-97 yuki-97 merged commit 733c7d6 into main Apr 15, 2026
27 checks passed
@yuki-97 yuki-97 deleted the degert/dcp-conversion-fix branch April 15, 2026 05:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

CI:Lfast Runs a fast test suite and re-use nightly `main` container (but sync dependencies to PRs version)

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants