feat: Support aux loss normalization in RL SFT#2194
Draft
Conversation
Remove the MoE aux loss assertion that blocked aux_loss usage with calculate_per_token_loss=True. Add moe_grad_scale_func to properly normalize MOE auxiliary loss gradients: sets scale to 1/global_valid_toks before forward-backward and clears it after, so that after DDP SUM the aux loss gradient is correctly averaged. Also adds sft_nanov3.yaml config for nano-v3 SFT training with MoE seq_aux_loss enabled. Signed-off-by: Pranav Prashant Thombre <pthombre@nvidia.com>
e1dcc07 to
136fa39
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this PR do ?
Remove the MoE aux loss assertion that blocked aux_loss usage with calculate_per_token_loss=True. Add moe_grad_scale_func to properly normalize MOE auxiliary loss gradients: sets scale to 1/global_valid_toks before forward-backward and clears it after, so that after DDP SUM the aux loss gradient is correctly averaged.
Also adds sft_nanov3.yaml config for nano-v3 SFT training with MoE seq_aux_loss enabled.
Issues
List issues that this PR closes (syntax):
Usage
# Add a code snippet demonstrating how to use thisBefore your PR is "Ready for review"
Pre checks:
Additional Information