Skip to content

fix: Move code copy to last docker stage#15761

Merged
chtruong814 merged 1 commit into
mainfrom
chtruong/docker-stage
Jun 7, 2026
Merged

fix: Move code copy to last docker stage#15761
chtruong814 merged 1 commit into
mainfrom
chtruong/docker-stage

Conversation

@chtruong814
Copy link
Copy Markdown
Collaborator

Important

The Update branch button must only be pressed in very rare occassions.
An outdated branch is never blocking the merge of a PR.
Please reach out to the automation team before pressing that button.

What does this PR do ?

fix: Move code copy to last docker stage

Collection: [Note which collection this PR will affect]

Changelog

  • Add specific line by line info of high level changes in this PR.

Usage

  • You can potentially add a usage example below
# Add a code snippet demonstrating how to use this 

GitHub Actions CI

The Jenkins CI system has been replaced by GitHub Actions self-hosted runners.

The GitHub Actions CI will run automatically when the "Run CICD" label is added to the PR.
To re-run CI remove and add the label again.
To run CI on an untrusted fork, a NeMo user with write access must first click "Approve and run".

Before your PR is "Ready for review"

Pre checks:

  • Make sure you read and followed Contributor guidelines
  • Did you write any new necessary tests?
  • Did you add or update any necessary documentation?
  • Does the PR affect components that are optional to install? (Ex: Numba, Pynini, Apex etc)
    • Reviewer: Does the PR have correct import guards for all optional libraries?

PR Type:

  • New Feature
  • Bugfix
  • Documentation

If you haven't finished some of the above items you can still open "Draft" PR.

Who can review?

Anyone in the community is free to review the PR once the checks have passed.
Contributor guidelines contains specific people who can review PRs to various areas.

Additional Information

  • Related to # (issue)

Signed-off-by: Charlie Truong <chtruong@nvidia.com>
@chtruong814 chtruong814 requested a review from a team as a code owner June 5, 2026 21:28
Comment thread docker/Dockerfile
fi
EOF

ENV NEMO_HOME="/home/TestData/nemo_home"
Copy link
Copy Markdown
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We probably shouldn't bake this into the container because it's a test env var. This is now passed during the CI test.

@chtruong814
Copy link
Copy Markdown
Collaborator Author

/ok to test 88c3079

@github-actions
Copy link
Copy Markdown
Contributor

github-actions Bot commented Jun 6, 2026

[🤖]: Hi @chtruong814 👋,

We wanted to let you know that a CICD pipeline for this PR just finished successfully.

So it might be time to merge this PR or get some approvals.

@chtruong814 chtruong814 merged commit 160a742 into main Jun 7, 2026
221 of 228 checks passed
@chtruong814 chtruong814 deleted the chtruong/docker-stage branch June 7, 2026 14:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants