fix: Move git refs for deep-ep and transformer engine to uv sources#15758
Open
chtruong814 wants to merge 3 commits into
Open
fix: Move git refs for deep-ep and transformer engine to uv sources#15758chtruong814 wants to merge 3 commits into
chtruong814 wants to merge 3 commits into
Conversation
Signed-off-by: Charlie Truong <chtruong@nvidia.com>
thomasdhc
previously approved these changes
Jun 5, 2026
ko3n1g
reviewed
Jun 5, 2026
| [tool.uv.sources] | ||
| nemo_automodel = { git = "https://github.com/NVIDIA-NeMo/Automodel.git", rev = "9eccbb6102a260efd7cbdffa890fc57b94f94528" } | ||
| deep_ep = { git = "https://github.com/deepseek-ai/DeepEP.git", tag = "v1.2.1" } | ||
| transformer-engine = { git = "https://github.com/NVIDIA/TransformerEngine.git", tag = "v2.15" } |
Contributor
There was a problem hiding this comment.
Why define it here when it’s also on PyPi?
Collaborator
Author
There was a problem hiding this comment.
I guess it should force a build if their wheel does not match the torch version right? Speech is using public torch 2.12.
Signed-off-by: Charlie Truong <chtruong@nvidia.com>
Signed-off-by: Charlie Truong <chtruong@nvidia.com>
Collaborator
Author
|
/ok to test da8bb04 |
ko3n1g
approved these changes
Jun 5, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Important
The
Update branchbutton must only be pressed in very rare occassions.An outdated branch is never blocking the merge of a PR.
Please reach out to the automation team before pressing that button.
What does this PR do ?
fix: Move git refs for deep-ep and transformer engine to uv sources
The pypi build was failing because some dependencies had git refs, which is not compatible with pypi. Move those to uv.sources to make it work with uv installs.
Add a one line overview of what this PR aims to accomplish.
Collection: [Note which collection this PR will affect]
Changelog
Usage
# Add a code snippet demonstrating how to use thisGitHub Actions CI
The Jenkins CI system has been replaced by GitHub Actions self-hosted runners.
The GitHub Actions CI will run automatically when the "Run CICD" label is added to the PR.
To re-run CI remove and add the label again.
To run CI on an untrusted fork, a NeMo user with write access must first click "Approve and run".
Before your PR is "Ready for review"
Pre checks:
PR Type:
If you haven't finished some of the above items you can still open "Draft" PR.
Who can review?
Anyone in the community is free to review the PR once the checks have passed.
Contributor guidelines contains specific people who can review PRs to various areas.
Additional Information