Handle missing validation_ds in RNNT BPE transcribe#15752
Open
basnijholt wants to merge 1 commit into
Open
Conversation
Signed-off-by: Bas Nijholt <bas@nijho.lt>
b7fb204 to
37d1e85
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Important
The
Update branchbutton must only be pressed in very rare occassions.An outdated branch is never blocking the merge of a PR.
Please reach out to the automation team before pressing that button.
What does this PR do ?
Handle RNNT BPE checkpoints that restore with
validation_ds: nulland then fail duringtranscribe()setup.Collection: ASR
Changelog
validation_dsas an empty config inEncDecRNNTBPEModel._setup_transcribe_dataloader.use_start_end_token=Falsewhen there is no validation dataset config.Usage
This showed up in agent-cli while adding a Whisper-compatible NeMo backend for NVIDIA Parakeet models: basnijholt/agent-cli#436
Our daemon use case is:
The
nvidia/parakeet-unified-en-0.6bcheckpoint restores as an RNNT BPE model withvalidation_ds: null. Before this change,transcribe()crashes before decoding audio:agent-cli has a downstream workaround for this in basnijholt/agent-cli#576, but NeMo can handle the checkpoint config directly.
GitHub Actions CI
The GitHub Actions CI will run automatically when the "Run CICD" label is added to the PR.
To re-run CI remove and add the label again.
To run CI on an untrusted fork, a NeMo user with write access must first click "Approve and run".
Before your PR is "Ready for review"
Pre checks:
PR Type:
If you haven't finished some of the above items you can still open "Draft" PR.
Who can review?
Anyone in the community is free to review the PR once the checks have passed.
Contributor guidelines contains specific people who can review PRs to various areas.
Additional Information
uv run --frozen --no-sync pytest tests/collections/asr/test_asr_rnnt_encoder_model_bpe.py -q(2 passed, 8 skipped)