fix: Relative paths for ng_init_resources_server#937
fix: Relative paths for ng_init_resources_server#937bogdansalyp wants to merge 8 commits intoNVIDIA-NeMo:mainfrom
Conversation
Signed-off-by: Bogdan Salyp <bogdansalyp@gmail.com>
Signed-off-by: Bogdan Salyp <bogdansalyp@gmail.com>
6ec436f to
e2a4638
Compare
Signed-off-by: Bogdan Salyp <bogdansalyp@gmail.com>
|
@bxyu-nvidia or maybe I can add |
|
hi @bogdansalyp thanks for the PR! resources servers outside of the local Gym install should already be possible. see this #649 This will search i am not sure about also note that there seems to be a bug in the pypi build #935 that we are looking into. in the meantime, i think pip install the local clone should suffice |
|
@cmunley1 thanks, I'll check and return back soon |
This reverts commit 87fc340. Signed-off-by: Bogdan Salyp <bogdansalyp@gmail.com>
37f71c1 to
2d41014
Compare
This reverts commit e2a4638. Signed-off-by: Bogdan Salyp <bogdansalyp@gmail.com>
Signed-off-by: Bogdan Salyp <bogdansalyp@gmail.com>
|
@cmunley1 I've reverted |
|
Also I've checked I have a fix for that too but it's better to make it a separate PR when this one is merged |
|
@bxyu-nvidia can you please review this PR? |
|
@bogdansalyp can you try this branch? I pulled in your changes. #972 |
|
@bogdansalyp we pulled some of these changes into the 0.2.1 release, thanks again for flagging this, could you please retry with nemo-gym==0.2.1? |
TL;DR
Allows users to use
ng_init_resources_serverfrom any location with any relative paths.Tested scenarios
Tested on a file structure like:
1. Create a relative path resource server
2. Create a resource server FROM a relative path
Both commands:
requirements.txtwith a correct path to Gym packagecloses #936