Skip to content

chore: mark docs maintenance skill internal#733

Open
johnnygreco wants to merge 1 commit into
mainfrom
johnny/chore-hide-datadesigner-docs-skill
Open

chore: mark docs maintenance skill internal#733
johnnygreco wants to merge 1 commit into
mainfrom
johnny/chore-hide-datadesigner-docs-skill

Conversation

@johnnygreco
Copy link
Copy Markdown
Contributor

📋 Summary

Hide the contributor-only datadesigner-docs skill from generic skills.sh discovery. The public install flow should only offer the user-facing data-designer skill.

🔗 Related Issue

N/A

🔄 Changes

  • Add metadata.internal: true to .agents/skills/datadesigner-docs/SKILL.md, matching the other internal .agents/skills entries.

🧪 Testing

  • git diff --check
  • npx --yes skills add . --list shows only data-designer
  • Unit tests added/updated: N/A — skill metadata only
  • E2E tests added/updated: N/A — skill metadata only

✅ Checklist

  • Follows commit message conventions
  • Commits are signed off (DCO)
  • Architecture docs updated: N/A — internal skill metadata only

Signed-off-by: Johnny Greco <jogreco@nvidia.com>
@johnnygreco johnnygreco requested a review from a team as a code owner June 2, 2026 17:51
@johnnygreco johnnygreco deployed to agentic-ci June 2, 2026 17:51 — with GitHub Actions Active
@greptile-apps
Copy link
Copy Markdown
Contributor

greptile-apps Bot commented Jun 2, 2026

Greptile Summary

Adds metadata: internal: true to the datadesigner-docs skill's frontmatter so that the public skills.sh discovery flow hides it, matching the identical pattern already present in commit, create-pr, review-code, and search-docs.

  • The one-line YAML change uses the same 4-space indented metadata: / internal: true block found in every other internal skill — no formatting drift.
  • No runtime code, tests, or functional behaviour is affected; this is a skill-metadata-only change.

Confidence Score: 5/5

This is a one-field YAML metadata addition with no code or logic changes; safe to merge.

The change exactly mirrors the metadata: internal: true block already present in every other contributor-only skill in the repo. There is nothing that could regress or break.

No files require special attention.

Important Files Changed

Filename Overview
.agents/skills/datadesigner-docs/SKILL.md Adds metadata: internal: true to the YAML frontmatter, matching the identical pattern used in all other internal skills in .agents/skills/. No logic changes.

Flowchart

%%{init: {'theme': 'neutral'}}%%
flowchart TD
    A[skills.sh / npx skills add . --list] --> B{metadata.internal == true?}
    B -- Yes --> C[Hidden from public listing]
    B -- No --> D[Shown to users]

    subgraph Internal Skills [Internal Skills - hidden]
        C --> E[commit]
        C --> F[create-pr]
        C --> G[review-code]
        C --> H[search-docs]
        C --> I[search-github]
        C --> J[update-pr]
        C --> K[datadesigner-docs - this PR]
    end

    subgraph Public Skills [Public Skills - visible]
        D --> L[data-designer]
    end
Loading

Reviews (1): Last reviewed commit: "chore: mark docs maintenance skill inter..." | Re-trigger Greptile

@github-actions
Copy link
Copy Markdown
Contributor

github-actions Bot commented Jun 2, 2026

Code Review: PR #733 — chore: mark docs maintenance skill internal

Summary

This PR adds metadata.internal: true to .agents/skills/datadesigner-docs/SKILL.md so the contributor-only docs maintenance skill is hidden from generic skills.sh discovery. Public installs should only surface the user-facing data-designer skill. The diff is 2 lines added across 1 file.

Findings

Correctness

  • The added frontmatter exactly matches the pattern already used by every other internal skill in .agents/skills/: commit, create-pr, update-pr, review-code, search-docs, and search-github all carry metadata.internal: true. The datadesigner-docs skill was the lone outlier among contributor-facing skills, so this change brings it into alignment.
  • YAML structure is valid — the metadata mapping is placed inside the existing frontmatter block before the closing ---, matching the layout in neighboring SKILL.md files.

Style / Conventions

  • Indentation (4 spaces) of the internal: true key matches the other internal skill files. Consistent.
  • No description, argument-hint, or other front-matter fields were disturbed.

Testing

  • The PR description notes manual verification via npx --yes skills add . --list showing only data-designer is offered. That is the appropriate smoke test for this kind of metadata change; no automated test coverage is warranted.

Risk / Blast radius

  • Metadata-only change in a single contributor-tooling file. No runtime code, no published package contents, no docs site content (fern/) is touched. No import-direction or layering concerns. Effectively zero risk to library users.

Suggestions

  • None. The change is minimal, correct, and consistent with the established convention.

Verdict

LGTM. Trivial, well-scoped chore that closes a small gap in the internal-skill metadata convention. Safe to merge.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants