feat: more efficient KD loss with TP#1322
Closed
Separius wants to merge 3 commits intoNVIDIA-NeMo:mainfrom
Closed
Conversation
similar to [modelopt](https://github.com/NVIDIA/Model-Optimizer/blob/9e38041d346d8ee95bc17825ec59f7b91a3e59fc/modelopt/torch/distill/plugins/megatron.py#L292) instead of gathering the logits, we can calculate softmax on each TP with minimal communications
Separius
requested review from
HuiyingLi,
ZhiyuLi-Nvidia,
adil-a,
akoumpa and
hemildesai
as code owners
akoumpa
changed the title
Contributor
|
Thanks a lot @Separius , sorry for the delay, unfortunately, i see some unit tests fail, can you take a look? Thank you. |
Contributor
|
/ok to test 4ec05cf |
Contributor
|
/ok to test 3fa0a80 |
Contributor
Author
|
resubmitted in #1499 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
similar to modelopt instead of gathering the logits, we can calculate softmax on each TP with minimal communications
What does this PR do ?
Add a one line overview of what this PR aims to accomplish.
Changelog
Before your PR is "Ready for review"
Pre checks:
If you haven't finished some of the above items you can still open "Draft" PR.
Additional Information