fix(recipes): remove deprecated fully_shard() kwargs#1585
Open
svc-bionemo wants to merge 2 commits into
Open
Conversation
Remove grad_reduce_in_fp32, preserve_fp32_weights, and check_for_nan_in_grad kwargs from fully_shard() calls in vit, esm2_native_te, and geneformer_native_te_mfsdp_fp8 recipes. These parameters were removed in a recent megatron-core update. Fixes: NVIDIA-BioNeMo#1584 Signed-off-by: svc-bionemo <267129667+svc-bionemo@users.noreply.github.com>
svc-bionemo
requested review from
jstjohn,
jwilber,
pstjohn and
trvachov
as code owners
Contributor
|
Important Review skippedAuto reviews are disabled on this repository. Please check the settings in the CodeRabbit UI or the ⚙️ Run configurationConfiguration used: Path: .coderabbit.yaml Review profile: CHILL Plan: Pro Plus Run ID: You can disable this status message by setting the Use the checkbox below for a quick retry:
✨ Finishing Touches🧪 Generate unit tests (beta)
Comment |
Collaborator
|
/ok to test 7fe5c2d |
pstjohn
approved these changes
Jun 2, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Remove deprecated
fully_shard()keyword arguments that were removed in a recent megatron-core update.Changes
grad_reduce_in_fp32andpreserve_fp32_weightsfromfully_shard()callcheck_for_nan_in_grad,grad_reduce_in_fp32,preserve_fp32_weightsRoot Cause
The installed megatron-core in CI has updated
fully_shard()API, removing these parameters:grad_reduce_in_fp32preserve_fp32_weightscheck_for_nan_in_gradThese were simple removals — no replacement mechanism needed for the affected recipes.
Fixes #1584 (partially — the
nvidia-resiliency-extversion mismatch is a container image issue requiring an image rebuild)Testing
fully_shardloads without the removed kwargs