Skip to content

Enabled ExistentialAny setting#8

Merged
NSFatalError merged 2 commits intomainfrom
chore/review
Apr 24, 2025
Merged

Enabled ExistentialAny setting#8
NSFatalError merged 2 commits intomainfrom
chore/review

Conversation

@NSFatalError
Copy link
Owner

@NSFatalError NSFatalError commented Apr 24, 2025

Summary by CodeRabbit

  • Refactor

    • Updated error type annotations to use the new any Error syntax for improved Swift 6 compatibility.
  • Chores

    • Enabled Swift 6 language mode and opted into the "ExistentialAny" feature for all build targets.

@NSFatalError NSFatalError self-assigned this Apr 24, 2025
@coderabbitai
Copy link

coderabbitai bot commented Apr 24, 2025

Walkthrough

The changes update the Swift package configuration to enable Swift 6 language features and the "ExistentialAny" experimental feature for all targets. In the TaskTimeLimit.swift source file, error type annotations are migrated from the protocol type Error to the existential type any Error in function signatures and enum cases. No changes are made to the control flow or error handling logic, and a comment referencing future closure isolation review is added.

Changes

File(s) Change Summary
Package.swift Adds a loop to set Swift 6 language mode and enable "ExistentialAny" feature for all targets' swiftSettings.
Sources/PrincipleConcurrency/TaskTimeLimit.swift Updates error type annotations from Error to any Error in function signatures and enum cases; adds a comment.

Poem

In the warren of code, a hop and a leap,
Swift 6 arrives, its features we keep.
"ExistentialAny" now joins the show,
Errors made clearer, as functions now flow.
A tweak to the package, a nibble, a fix—
The rabbit approves these new Swift tricks!
🐇✨


📜 Recent review details

Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between 27f8e68 and e7966db.

📒 Files selected for processing (2)
  • Package.swift (1 hunks)
  • Sources/PrincipleConcurrency/TaskTimeLimit.swift (2 hunks)
🧰 Additional context used
🧬 Code Graph Analysis (1)
Sources/PrincipleConcurrency/TaskTimeLimit.swift (1)
Sources/PrincipleConcurrency/SingleUseTransfer.swift (1)
  • take (69-71)
⏰ Context from checks skipped due to timeout of 90000ms (4)
  • GitHub Check: build-and-test (visionos)
  • GitHub Check: build-and-test (watchos)
  • GitHub Check: build-and-test (macos)
  • GitHub Check: build-and-test (ios)
🔇 Additional comments (5)
Package.swift (1)

57-62: Well-structured compiler settings for Swift 6 language features.

The added code properly enables Swift 6 language mode and the "ExistentialAny" feature for all targets in the package. This implementation:

  1. Correctly preserves any existing swift settings
  2. Enables the language features uniformly across all targets
  3. Supports the source code changes in TaskTimeLimit.swift where Error was changed to any Error

This is a clean approach to enabling these features package-wide.

Sources/PrincipleConcurrency/TaskTimeLimit.swift (4)

16-16: Proper Swift 6 error type annotation.

The update from Error to any Error correctly adopts Swift 6's explicit existential type syntax for the taskFinished case.


23-23: Proper Swift 6 error type annotation for autoclosure parameter.

The update of the timeLimitExceededError parameter from () -> Error to () -> any Error correctly adopts Swift 6's explicit existential type syntax.


35-35: Proper Swift 6 error type annotation for Result type.

The update of the task group's returning type from Result<Success, Error> to Result<Success, any Error> correctly adopts Swift 6's explicit existential type syntax.


42-43: Helpful documentation for future review.

Good addition of a comment referencing the need for a future review once closure isolation control is implemented. The included link to the Swift forums provides useful context for other developers.

✨ Finishing Touches
  • 📝 Generate Docstrings

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share
🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

  • Review comments: Directly reply to a review comment made by CodeRabbit. Example:
    • I pushed a fix in commit <commit_id>, please review it.
    • Generate unit testing code for this file.
    • Open a follow-up GitHub issue for this discussion.
  • Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
    • @coderabbitai generate unit testing code for this file.
    • @coderabbitai modularize this function.
  • PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
    • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
    • @coderabbitai read src/utils.ts and generate unit testing code.
    • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
    • @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

  • @coderabbitai pause to pause the reviews on a PR.
  • @coderabbitai resume to resume the paused reviews.
  • @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
  • @coderabbitai full review to do a full review from scratch and review all the files again.
  • @coderabbitai summary to regenerate the summary of the PR.
  • @coderabbitai generate docstrings to generate docstrings for this PR.
  • @coderabbitai generate sequence diagram to generate a sequence diagram of the changes in this PR.
  • @coderabbitai resolve resolve all the CodeRabbit review comments.
  • @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
  • @coderabbitai help to get help.

Other keywords and placeholders

  • Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
  • Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
  • Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (.coderabbit.yaml)

  • You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
  • Please see the configuration documentation for more information.
  • If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

  • Visit our Documentation for detailed information on how to use CodeRabbit.
  • Join our Discord Community to get help, request features, and share feedback.
  • Follow us on X/Twitter for updates and announcements.

@NSFatalError NSFatalError merged commit 1baec71 into main Apr 24, 2025
8 checks passed
@NSFatalError NSFatalError deleted the chore/review branch April 24, 2025 12:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant