Remove need for _template.yaml

[evagroenendijk]

Remove the need for _template.yaml as in issue #202

[evagroenendijk]

https://github.com/NNPDF/pineko/blob/f4097f29dec964e8b2c17818b502575ffa3444f0/tests/test_evolve.py#L55C1-L55C43

@scarlehoff Could I maybe just remove this test? I could make it check that the theory cards' Q0 is the same as the default one, but to me it seems a bit superfluous

[scarlehoff]

Sure, shuffling around the _template and the operators might change which tests are needed.

[felixhekhorn]

some quick things I noticed last week

[evagroenendijk]

@felixhekhorn The regression benchmark comparing convolved predictions failed, but the maximal relative difference is 0.03497747. Would you say it's close enough?

[scarlehoff]

The template name should be removed from here:

pineko/src/pineko/configs.py

Line 19 in 89304e2

"operator_card_template_name",

also the NEEDED_FILE (and then needs to be removed from scaffold.py)

[scarlehoff]

This small of a relative difference is ok I'd say.

[scarlehoff]

I meant to request changes 😅

[felixhekhorn]

@felixhekhorn The regression benchmark comparing convolved predictions failed, but the maximal relative difference is 0.03497747. Would you say it's close enough?

I'm quite worried by this

Your theory has a different evolution method than the default(iterate-exact vs truncated).The evolution method will be set to the default value iterate-exact, check if this is what you want
Warning! The number of iteration in the theory and template is different, (60 vs 1).The number of iterations will be set to default value 60, check if this is what you want

this sounds like we can no longer run actually truncated - i.e. we can no longer reproduce 4.0. If that would be true that must be changed. This might well explain the difference we observe. We want to enforce consistent settings, i.e. "if method=truncated then iterations=1", but we don't want to enforce method=exact everywhere.

[scarlehoff]

This has to do with the comment I left. We just want to ensure that the evolution settings are coming from the theory not from a constant setting.

[evagroenendijk]

@felixhekhorn The regression benchmark comparing convolved predictions failed, but the maximal relative difference is 0.03497747. Would you say it's close enough?

I'm quite worried by this

Your theory has a different evolution method than the default(iterate-exact vs truncated).The evolution method will be set to the default value iterate-exact, check if this is what you want
Warning! The number of iteration in the theory and template is different, (60 vs 1).The number of iterations will be set to default value 60, check if this is what you want

this sounds like we can no longer run actually truncated - i.e. we can no longer reproduce 4.0. If that would be true that must be changed. This might well explain the difference we observe. We want to enforce consistent settings, i.e. "if method=truncated then iterations=1", but we don't want to enforce method=exact everywhere.

You're right! I think here I ran the benchmark while using iterate-exact (which I hardcoded into template.py). But as Juan suggested I will now let the evolution method be totally determined by the theory card. Then it would also do truncated evolution

[scarlehoff]

Let me know when I should try to test this again!

Btw, perhaps it would be good to rebase on top of master (or merge the changes from master)?

[evagroenendijk]

@scarlehoff Yes thanks, I implemented the changes you suggested and made the necessary adjustment, let me know if you agree! Sorry, I took the day off on Friday so I just finished it today