Open
Conversation
This was
linked to
issues
Mar 31, 2026
Open
cschwan
reviewed
Apr 1, 2026
|
|
||
| /// Upgrades the internal data structures to their latest versions. | ||
| pub fn upgrade(&mut self) {} | ||
| pub const fn upgrade(&mut self) {} |
Contributor
There was a problem hiding this comment.
While the current implementation surely calls for const, it's possible that future implementation will be more complicated and thus will have to remove const, which would constitute a breaking change, I suppose.
| /// Per-dimension node coordinates (scales, x values, etc.). | ||
| #[new] | ||
| #[must_use] | ||
| #[allow(clippy::needless_pass_by_value)] |
Contributor
There was a problem hiding this comment.
Wouldn't it be better to fix the actual warning instead of disabling it?
| /// # Example | ||
| /// | ||
| /// In the case of Drell—Yan, there are the following orders: | ||
| /// In the case of Drell-Yan, there are the following orders: |
Contributor
There was a problem hiding this comment.
What's the problem with en-dashes here and below?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR aims to address once and for all the issues regarding missing/unclear documentations summarized in #393.
Remaining Todo: