Skip to content

ci: fix x86 cross-compilation linker and artifact syntax ;#504

Merged
felixhekhorn merged 1 commit intoNNPDF:masterfrom
gluonparticle:fix-maturin-build
Apr 14, 2026
Merged

ci: fix x86 cross-compilation linker and artifact syntax ;#504
felixhekhorn merged 1 commit intoNNPDF:masterfrom
gluonparticle:fix-maturin-build

Conversation

@gluonparticle
Copy link
Copy Markdown
Contributor

Summary

As discussed in #502 , I've separated the immediate Maturin build fix from the OIDC in the PR ;

Changes

  1. Installs gcc-multilib conditionally for the Linux x86 target, resolving the crti.o linker error that was preventing compilation.
  2. Updates actions/download-artifact syntax to v4 with the required pattern: block to resolve the failing release download step.

Verification:
I ran an end-to-end mock release on my fork using a dummy tag.

  • The x86 wheel compiles successfully (readelf confirms Class: ELF32).
  • The v4 artifact step was sucessful, and
  • The test suite clears successfully;

@gluonparticle
Copy link
Copy Markdown
Contributor Author

Hi @scarlehoff, Sorry to bother you, could you please have a quick review on this isolated Maturin build fix from last week?

The x86 cross-compilation passed locally, please let me know if any changes are required! ;

@felixhekhorn felixhekhorn added benchmarks Benchmark (or infrastructure) related rust Rust extension related labels Apr 7, 2026
Copy link
Copy Markdown
Contributor

@felixhekhorn felixhekhorn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Seems good. Thanks for the fix.

@felixhekhorn felixhekhorn merged commit f3d6de4 into NNPDF:master Apr 14, 2026
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

benchmarks Benchmark (or infrastructure) related rust Rust extension related

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants