Do not break DNSSEC for DNSSEC-aware clients when using block_a#1081
Open
Kaleb-Reid wants to merge 3 commits intoNLnetLabs:masterfrom
Open
Do not break DNSSEC for DNSSEC-aware clients when using block_a#1081Kaleb-Reid wants to merge 3 commits intoNLnetLabs:masterfrom
Kaleb-Reid wants to merge 3 commits intoNLnetLabs:masterfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is the desired behaviour according to #884 (comment). From what I was able to find, block_a already removed the AD bit from modified replys. This also added tests for the functionality of block_a, but I'm not entirely sure about the correctness of them so someone should look that over.
This should easily be adapted to #884.