CCM-13378: Handle no supplier available#552
Open
nhsd-david-wass wants to merge 26 commits intomainfrom
Open
Conversation
nhsd-david-wass
force-pushed
the
feature/CCM-13378-Handle-No-Supplier-Available
branch
8 times, most recently
from
4f77e15 to
7f516e2
Compare
stevebux
previously approved these changes
May 6, 2026
| const supplier = | ||
| !supplierSpec || !supplierSpec.supplierId | ||
| !allocationDetails?.supplierSpec || | ||
| !allocationDetails?.supplierSpec.supplierId |
Contributor
There was a problem hiding this comment.
I'm just trying to understand when supplierSpec and/or supplierId would be falsy. They're both mandatory fields on their respective parents (and supplierId can't be the empty string), so I think it would only happen when allocationDetails is undefined. If that's correct you may be able to simplify this logic
Vlasis-Perdikidis
approved these changes
May 6, 2026
nhsd-david-wass
force-pushed
the
feature/CCM-13378-Handle-No-Supplier-Available
branch
from
e997f67 to
4027cc4
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Context
Type of changes
Checklist
DT3-Specific Checklist
Sensitive Information Declaration
To ensure the utmost confidentiality and protect your and others privacy, we kindly ask you to NOT including PII (Personal Identifiable Information) / PID (Personal Identifiable Data) or any other sensitive data in this PR (Pull Request) and the codebase changes. We will remove any PR that do contain any sensitive information. We really appreciate your cooperation in this matter.