CCM-17440: Fix dependabot issues#321
Open
simonlabarere wants to merge 4 commits intomainfrom
Open
Conversation
0dfc38a to
2e522f2
Compare
7d404da to
63ce4d2
Compare
63ce4d2 to
72c1f93
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Updated the following dependencies:
node-joseuses a vulnerable version ofuuidand it couldn't be overridden (I hacked it to force it use a new version and node-jose wouldn't work because it detected something was wrong).I used copilot to replace
node-josewith a combination ofjose(which is maintained) andnode:crypto. The problem is thatjoseversion 6 (latest) is not compatible out of the box with the way we usejestfor testing. I spent some time trying to make it work but it involved using an experimental version ofjestand it made all the unit tests flaky in general. Version 5 ofjosedidn't have that problem so this is what I ended up using but it's a year old. On the other hand it doesn't have any vulnerabilities so it's still better than the 3 year old version ofnode-jose.Testing involved generating a new public/private key pair and making sure it's working with the APIM authentication mechanism.
Testing
Running the key-generation lambda manually
Generated private key
Generated public key
APIM Updated to point at pr321
Token generation
Type of changes
Checklist
Sensitive Information Declaration
To ensure the utmost confidentiality and protect your and others privacy, we kindly ask you to NOT including PII (Personal Identifiable Information) / PID (Personal Identifiable Data) or any other sensitive data in this PR (Pull Request) and the codebase changes. We will remove any PR that do contain any sensitive information. We really appreciate your cooperation in this matter.