Close a clinic workflow - #389
Open
rivalee wants to merge 19 commits into
Open
Conversation
edwardhorsford
temporarily deployed
to
manage-breas-close-clin-eeepfz
August 11, 2026 10:21
Inactive
edwardhorsford
temporarily deployed
to
manage-breas-close-clin-eeepfz
August 11, 2026 15:15
Inactive
edwardhorsford
temporarily deployed
to
manage-breas-close-clin-eeepfz
August 13, 2026 12:46
Inactive
- fix validation losing form answers, and modal onSuccess never firing - collapse eight action routes into parameterised set-status routes - share the attended-not-screened form fields between both flows - replace inline page script with close-clinic.js using server-rendered row fragments, so rows update in place after actions and modal saves - track close-flow resolved ids in session data; add updateClinic helper - move table styles out of _compact.scss; revert ANS tag colour to orange - seed some attended-not-screened appointments without details
- attended-not-screened fields become a context include, matching the repo's include convention - reschedule step now closes the modal and updates the row in place, matching the no-reschedule path
edwardhorsford
temporarily deployed
to
manage-breas-close-clin-eeepfz
August 14, 2026 14:27
Inactive
- fragment-actions.js: links and forms marked data-fragment-action are fetched, and the server's re-rendered data-fragment-id element is swapped in place; falls back to normal navigation without JS or on error - priors dashboard: row extracted to a macro rendered by a fragment route; deletes the inline script that duplicated status vocab and forms - clinic page check-in: row extracted to a macro; check-in route returns the re-rendered row and main.js swaps it instead of hand-patching tags - close clinic page moved onto the same convention
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Card: Closing a clinic workflow
Changes to clinic list
clinic CH435completed clinicstoclosed clinicsand
Clinic list with clinic names
Close clinic link
Close clinic page
Checked in, not screenedandDid not check incan be actioned en masse or individuallyIn progressis more complicated and need the mammographer to finish the appointmentValidation message
It's not possible to close a clinic until all participant outcomes are recorded, and we should show a validation message
Successfully closing a clinic
When the clinic is closed, the clinic moves from today to the closed list with a success banner