Increasing test coverage

[ORybak5]

What

Increasing the adaptor's test coverage

Why

The more tests that cover different scenarios, the better, as they increase confidence in the adaptor and help maintain quality

Type of change

Please delete options that are not relevant.

• Bug fix (non-breaking change which fixes an issue)
• New feature (non-breaking change which adds functionality)
• Internal change (non-breaking change with no effect on the functionality affecting end users)
• Breaking change (fix or feature that would cause existing functionality to not work as expected)

Checklist:

• I have performed a self-review of my code
• I have made corresponding changes to the documentation
• My changes generate no new warnings
• I have added tests that prove my fix is effective or that my feature works
• New and existing unit tests pass locally with my changes
• I have updated the Changelog with details of my change in the UNRELEASED section if this change will affect end users
• A corresponding change has been made to the Mapping Documentation repository

[github-actions]

Images built and published to ECR using a Build Id of PR-1151-b622ed6

[Copilot]

Pull request overview

This PR increases unit test coverage in the common module by adding new JUnit 5 tests for core utility/services, improving confidence in JSON/FHIR parsing and logging-context handling.

Changes:

• Add FhirParserTest covering parsing valid/invalid JSON into FHIR Parameters and encoding resources to JSON.
• Add MDCServiceTest covering setting/getting and resetting the conversation ID stored in SLF4J MDC.

Reviewed changes

Copilot reviewed 2 out of 2 changed files in this pull request and generated 1 comment.

File	Description
common/src/test/java/uk/nhs/adaptors/common/util/fhir/FhirParserTest.java	Adds unit tests for FHIR JSON parse/encode behavior and invalid JSON handling.
common/src/test/java/uk/nhs/adaptors/common/service/MDCServiceTest.java	Adds unit tests for applying and clearing the MDC conversation ID.

---

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

[github-actions]

Looks good. No mutations were possible for these changes.
See https://pitest.org