VED-1260 Mock PDS lambda rate limiting in ref env by amarauzoma · Pull Request #1427 · NHSDigital/immunisation-fhir-api

amarauzoma · 2026-04-17T11:58:33Z

Replaced deployed ref mock PDS dependency with local test-only mock tooling.
Added local PDS stub + dedicated Locust profile for average/boundary/spike rate-limit validation.
Added simple make commands with preset rates (125 average, 130 boundary, spike profile).
Updated docs and removed obsolete mock deployment wiring from infra/workflows.
Outcome: same rate-limit validation intent, cleaner and faster test execution, no unnecessary ref endpoint dependency.

- Added a new Lambda function to simulate PDS responses for patient lookups. - Implemented rate limiting with configurable average and spike thresholds. - Updated existing MNS publisher to utilize the new PDS base URL environment variable. - Enhanced tests to cover scenarios with the mock PDS service, including rate limit handling. - Created performance testing scripts to validate MNS behavior under load with the mock PDS. - Updated infrastructure to route PDS calls in the ref environment to the mock endpoint.

- Streamlined the initialization of MockPdsService by consolidating parameters. - Replaced multiple response methods with a unified error handling approach. - Enhanced readability by reducing redundant code in the patient lookup logic. - Updated tests to utilize helper functions for event creation and decision mocking.

- Deleted the performance testing plan document for MNS integration with mocked PDS. - This document outlined objectives, delivery approaches, and existing architecture for implementing a mocked PDS service.

…mock-PDS-in-Ref Made-with: Cursor # Conflicts: # tests/perf_tests/Makefile

- Removed the global service retrieval function and directly initialized the MockPdsService with a Redis client and rate limiter. - Updated the lambda_handler to use the initialized service directly, improving performance and readability. - Adjusted unit tests to accommodate the new service initialization approach, ensuring proper mocking and error handling.

… tests - Updated sonar-project.properties to include coverage report for mock_pds. - Added new unit tests for Mock PDS service to improve test coverage and handle edge cases. - Introduced a new test file for rate limiting functionality in the Mock PDS service. - Updated the quality-checks workflow to run tests for the new mock_pds service.

- Introduced a new Mock PDS Lambda function to simulate PDS responses. - Created an ECR repository for the Mock PDS service with appropriate policies. - Updated deployment workflows to include mock_pds in build flags and image overrides. - Enhanced infrastructure configuration to support the new Mock PDS service, including image URI handling and environment variable setup.

avshetty1980

Nice, just a few nits.
I like the average + spike rate limiting with Redis atomicity per window

…ecurity

…mand

… server for rate limit testing

…ved clarity and maintainability

…E path

…ific jobs

…ient lookup functionality - Add pyproject.toml for dependency management using Poetry - Create lambda_handler.py to handle incoming requests and integrate with MockPdsService - Implement MockPdsService to manage patient lookup and rate limiting logic - Introduce FixedWindowRateLimiter for controlling request rates using Redis - Add unit tests for MockPdsService and rate limiter functionality - Update performance test setup to target deployed mock PDS Lambda instead of local server - Remove local mock server implementation and related references from performance tests

…y poetry installation

sonarqubecloud · 2026-05-07T12:28:06Z

Quality Gate failed

Failed conditions
17.7% Coverage on New Code (required ≥ 80%)
C Security Rating on New Code (required ≥ A)

See analysis details on SonarQube Cloud

Catch issues before they fail your Quality Gate with our IDE extension SonarQube for IDE

+RUN mkdir -p /home/appuser && \
+    echo 'appuser:x:1001:1001::/home/appuser:/sbin/nologin' >> /etc/passwd && \
+    echo 'appuser:x:1001:' >> /etc/group && \
+    chown -R 1001:1001 /home/appuser && pip install "poetry~=2.1.4"


+RUN mkdir -p /home/appuser && \
+    echo 'appuser:x:1001:1001::/home/appuser:/sbin/nologin' >> /etc/passwd && \
+    echo 'appuser:x:1001:' >> /etc/group && \
+    chown -R 1001:1001 /home/appuser && pip install "poetry~=2.1.4"


+COPY ./mock_pds/poetry.lock ./mock_pds/pyproject.toml ./
+
+WORKDIR /var/task
+RUN poetry config virtualenvs.create false && poetry install --no-interaction --no-ansi --no-root --only main


amarauzoma and others added 2 commits April 17, 2026 12:51

amarauzoma changed the title ~~feat: Introduce Mock PDS Lambda for MNS integration testing~~ VED-1235 Lambda-to-mock-PDS-in-Ref Apr 17, 2026

Thomas-Boyle added 2 commits April 17, 2026 13:03

chore: Remove MNS performance testing plan for mocked PDS

d7421df

- Deleted the performance testing plan document for MNS integration with mocked PDS. - This document outlined objectives, delivery approaches, and existing architecture for implementing a mocked PDS service.

Merge remote-tracking branch 'origin/master' into VED-1235-Lambda-to-…

28cac67

…mock-PDS-in-Ref Made-with: Cursor # Conflicts: # tests/perf_tests/Makefile

Thomas-Boyle temporarily deployed to dev April 17, 2026 12:12 — with GitHub Actions Inactive

Thomas-Boyle temporarily deployed to dev April 17, 2026 12:13 — with GitHub Actions Inactive

Thomas-Boyle had a problem deploying to dev April 17, 2026 12:14 — with GitHub Actions Error

Thomas-Boyle temporarily deployed to dev April 17, 2026 12:23 — with GitHub Actions Inactive

Thomas-Boyle temporarily deployed to dev April 17, 2026 12:24 — with GitHub Actions Inactive

Thomas-Boyle temporarily deployed to internal-dev April 17, 2026 12:27 — with GitHub Actions Inactive

Thomas-Boyle temporarily deployed to internal-dev-sandbox April 17, 2026 12:27 — with GitHub Actions Inactive

Thomas-Boyle temporarily deployed to internal-dev-sandbox April 17, 2026 12:28 — with GitHub Actions Inactive

Thomas-Boyle had a problem deploying to internal-dev April 17, 2026 12:28 — with GitHub Actions Error

Thomas-Boyle temporarily deployed to dev April 17, 2026 12:35 — with GitHub Actions Inactive

Thomas-Boyle temporarily deployed to dev April 17, 2026 12:36 — with GitHub Actions Inactive

Thomas-Boyle temporarily deployed to internal-dev April 17, 2026 12:40 — with GitHub Actions Inactive

Thomas-Boyle temporarily deployed to internal-dev-sandbox April 17, 2026 12:40 — with GitHub Actions Inactive

Thomas-Boyle had a problem deploying to internal-dev April 17, 2026 12:40 — with GitHub Actions Error

Thomas-Boyle temporarily deployed to internal-dev-sandbox April 17, 2026 12:40 — with GitHub Actions Inactive

Disable mock PDS in development environment

bdf2fe4

Thomas-Boyle previously approved these changes Apr 22, 2026

View reviewed changes