New: [AEA-6028] - Added shared code for CDK and Proxygen deployments #432
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This PR is linked to a ticket in an NHS Digital JIRA Project. Here's a handy link to the ticket: AEA-6028 |
MatthewPopat-NHS
had a problem deploying
to
dev
GitHub Actions
Failure
MatthewPopat-NHS
had a problem deploying
to
dev
GitHub Actions
Failure
MatthewPopat-NHS
had a problem deploying
to
dev
GitHub Actions
Failure
anthony-nhs
reviewed
Jan 13, 2026
anthony-nhs
reviewed
Jan 13, 2026
| spec["x-nhsd-apim"].target.url = `https://${stackName}.${awsEnvironment}.eps.national.nhs.uk` | ||
| if (apigeeEnvironment === "prod") { | ||
| spec.servers = [ {url: `https://api.service.nhs.uk/${instance}`} ] | ||
| spec.components.securitySchemes["nhs-cis2-aal3"] = { |
Contributor
There was a problem hiding this comment.
should have nhs-login-p9 as well - see https://github.com/NHSDigital/prescriptionsforpatients/blob/main/.github/scripts/deploy_api.sh#L80C133-L80C146
Contributor
There was a problem hiding this comment.
anthony-nhs
reviewed
Jan 13, 2026
| proxygenKid: string | ||
| } | ||
|
|
||
| export async function deployApi( |
Contributor
There was a problem hiding this comment.
how will this deal when we need to delete something from the spec in prod - https://github.com/NHSDigital/eps-prescription-status-update-api/blob/main/.github/scripts/deploy_api.sh#L105
Contributor
There was a problem hiding this comment.
we also do this in fhir api
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary