Skip to content

DSTA-570: markdown creted for user RBAC#45

Merged
wlyagoba merged 5 commits into
mainfrom
feat/DSTA-570-key-vault-rbac
Jun 30, 2026
Merged

DSTA-570: markdown creted for user RBAC#45
wlyagoba merged 5 commits into
mainfrom
feat/DSTA-570-key-vault-rbac

Conversation

@wlyagoba

Copy link
Copy Markdown
Contributor

Key Vault RBAC for users

This markdown file details to access/create/set permissions to the key vault via azure cli

Type of changes

  • Refactoring (non-breaking change)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would change existing functionality)
  • Bug fix (non-breaking change which fixes an issue)

Checklist

  • I am familiar with the contributing guidelines
  • I have followed the code style of the project
  • I have added tests to cover my changes
  • I have updated the documentation accordingly
  • This PR is a result of pair or mob programming

Sensitive Information Declaration

To ensure the utmost confidentiality and protect your and others privacy, we kindly ask you to NOT including PII (Personal Identifiable Information) / PID (Personal Identifiable Data) or any other sensitive data in this PR (Pull Request) and the codebase changes. We will remove any PR that do contain any sensitive information. We really appreciate your cooperation in this matter.

  • I confirm that neither PII/PID nor sensitive data are included in this PR and the codebase changes.

Signed-off-by: wlyagoba <william.lyagoba1@nhs.net>

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Adds a new Markdown guide under nbss/ documenting how to use Azure CLI to create Key Vault secrets, assign RBAC permissions for users/groups, and retrieve secrets.

Changes:

  • Introduces step-by-step Azure CLI instructions for logging in, setting variables, creating secrets, and granting RBAC at secret scope
  • Adds quick reference for relevant Key Vault RBAC roles
  • Includes lookup commands for user/group object IDs

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Comment thread nbss/keyvault.md Outdated
Comment thread nbss/keyvault.md Outdated
wlyagoba and others added 2 commits June 29, 2026 11:24
Co-authored-by: Copilot Autofix powered by AI <175728472+Copilot@users.noreply.github.com>
Co-authored-by: Copilot Autofix powered by AI <175728472+Copilot@users.noreply.github.com>
Comment thread nbss/keyvault.md Outdated
wlyagoba added 2 commits June 30, 2026 12:52
Signed-off-by: wlyagoba <william.lyagoba1@nhs.net>
Signed-off-by: wlyagoba <william.lyagoba1@nhs.net>

@LouisD7 LouisD7 left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me

@wlyagoba wlyagoba merged commit 7f17a7b into main Jun 30, 2026
8 checks passed
@wlyagoba wlyagoba deleted the feat/DSTA-570-key-vault-rbac branch June 30, 2026 12:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants