Ensure record level rejections are working#117

Merged

stevenhsd merged 4 commits into

release_v082from

fix/gr-ndit-1535-ensure_record_level_rejections_are_working

Jun 30, 2026

SonarQubeCloud / SonarCloud Code Analysis succeeded Jun 29, 2026 in 28s

Quality Gate passed

Issues
4 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube Cloud

Annotations

Check warning on line 637 in src/dve/pipeline/pipeline.py

sonarqubecloud / SonarCloud Code Analysis

Complete the task associated to this "TODO" comment.

See more on https://sonarcloud.io/project/issues?id=NHSDigital_data-validation-engine&issues=AZ8TQf7iG0HmfgRSgg1S&open=AZ8TQf7iG0HmfgRSgg1S&pullRequest=117

Check failure on line 108 in src/dve/core_engine/models.py

sonarqubecloud / SonarCloud Code Analysis

Add an explicit default value to this optional field.

See more on https://sonarcloud.io/project/issues?id=NHSDigital_data-validation-engine&issues=AZ8TQf6-G0HmfgRSgg1Q&open=AZ8TQf6-G0HmfgRSgg1Q&pullRequest=117

Check failure on line 768 in src/dve/pipeline/pipeline.py

sonarqubecloud / SonarCloud Code Analysis

Define a constant instead of duplicating this literal "Record Rejection" 3 times.

See more on https://sonarcloud.io/project/issues?id=NHSDigital_data-validation-engine&issues=AZ8TQf7hG0HmfgRSgg1R&open=AZ8TQf7hG0HmfgRSgg1R&pullRequest=117

Check warning on line 397 in src/dve/core_engine/backends/implementations/spark/spark_helpers.py

sonarqubecloud / SonarCloud Code Analysis

Complete the task associated to this "TODO" comment.

See more on https://sonarcloud.io/project/issues?id=NHSDigital_data-validation-engine&issues=AZ8TQf3RG0HmfgRSgg1P&open=AZ8TQf3RG0HmfgRSgg1P&pullRequest=117

View more details on SonarQubeCloud