[GPCAPIM-289]-[Pass integration tests through APIM proxy (with mock CIS2)]-[RP]#101
[GPCAPIM-289]-[Pass integration tests through APIM proxy (with mock CIS2)]-[RP]#101BJSS-russell-pollock wants to merge 1 commit intomainfrom
Conversation
BJSS-russell-pollock
force-pushed
the
feature/GPCAPIM-289
branch
4 times, most recently
from
df1f8b1 to
b2e781a
Compare
BJSS-russell-pollock
force-pushed
the
feature/GPCAPIM-289
branch
from
b2e781a to
f9e5838
Compare
BJSS-russell-pollock
force-pushed
the
feature/GPCAPIM-289
branch
20 times, most recently
from
f091e19 to
444df7e
Compare
BJSS-russell-pollock
force-pushed
the
feature/GPCAPIM-289
branch
14 times, most recently
from
57c54ca to
d90a051
Compare
|
✅ Trivy gate: no Critical/High vulnerabilities. Trivy Filesystem Scan SummaryFilesystem: infrastructure/environments/preview
✅ No vulnerabilities found. |
|
✅ Trivy gate: no Critical/High vulnerabilities. Trivy Filesystem Scan SummaryFilesystem: .
✅ No vulnerabilities found. |
BJSS-russell-pollock
force-pushed
the
feature/GPCAPIM-289
branch
7 times, most recently
from
f9af754 to
0a50194
Compare
BJSS-russell-pollock
force-pushed
the
feature/GPCAPIM-289
branch
from
0a50194 to
ee0dd9f
Compare
|
|
Deployment Complete
|
| @@ -0,0 +1,84 @@ | |||
| name: "Run test suite" | |||
| description: | | |||
| Composite action that runs a single test type (unit/contract/schema/integration/acceptance), | |||
There was a problem hiding this comment.
Composite action that can run any one of the test types: unit/contract/schema/integration/acceptance
There was a problem hiding this comment.
or
Composite action that is used to run the test types:
| name: "Run test suite" | ||
| description: | | ||
| Composite action that runs a single test type (unit/contract/schema/integration/acceptance), | ||
| uploads the test artefacts, and publishes a JUnit summary to the GitHub Actions job. |
| required: true | ||
| apigee-access-token: | ||
| description: "Apigee access token" | ||
| required: false |
There was a problem hiding this comment.
if the env defaults to remote:
env:
description: "Environment: local or remote"
required: false
default: "remote"
as you have further down - should this 'apigee-access-token' default to true as you say above that this token is required for a remote run?
| ENV: ${{ inputs.env }} | ||
| run: | | ||
| if [[ -n "${APIGEE_ACCESS_TOKEN}" ]]; then | ||
| echo "::add-mask::${APIGEE_ACCESS_TOKEN}" |
There was a problem hiding this comment.
what does this do?
if it masks the log when why log it out?
| - name: Retrieve Apigee Token | ||
| id: apigee-token | ||
| shell: bash | ||
| run: | |
There was a problem hiding this comment.
run: set -euo pipefail
| if: always() | ||
| run: | | ||
| [ -f "gateway-api/test-artefacts/contract-tests.xml" ] && echo "exists=true" >> "$GITHUB_OUTPUT" || echo "exists=false" >> "$GITHUB_OUTPUT" | ||
| echo "::add-mask::$APIGEE_TOKEN" |
There was a problem hiding this comment.
same question about the mask
| [ -f "gateway-api/test-artefacts/contract-tests.xml" ] && echo "exists=true" >> "$GITHUB_OUTPUT" || echo "exists=false" >> "$GITHUB_OUTPUT" | ||
| echo "::add-mask::$APIGEE_TOKEN" | ||
| printf 'apigee-access-token=%s\n' "$APIGEE_TOKEN" >> "$GITHUB_OUTPUT" | ||
| echo "Token retrieved successfully (length: ${#APIGEE_TOKEN})" |
There was a problem hiding this comment.
does this need the mask?
| STUB_SDS: "true" | ||
| STUB_PDS: "true" | ||
| STUB_PROVIDER: "true" | ||
| ENV: "local" |
There was a problem hiding this comment.
if we are setting the ENV as remote or local on each of the specific test jobs why do we need it here?
2 participants
Description
To allow for the CI process to run before the APIM integration has been completed, the tests are currently executed against a container running within the same process, which invokes the lambda in the same way as it would be ran within AWS. This ticket looks to alter the target of the tests to instead point at the deployed APIM proxy for the Pull Request.
Type of changes
Checklist
Sensitive Information Declaration
To ensure the utmost confidentiality and protect your and others privacy, we kindly ask you to NOT including PII (Personal Identifiable Information) / PID (Personal Identifiable Data) or any other sensitive data in this PR (Pull Request) and the codebase changes. We will remove any PR that do contain any sensitive information. We really appreciate your cooperation in this matter.