Skip to content

fix(docker): add multi-arch (amd64/arm64) Docker build support #130

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
MuhammadAbeerAkmal wants to merge 1 commit into
base: development
Choose a base branch
from
Open

fix(docker): add multi-arch (amd64/arm64) Docker build support #130

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 5 additions & 0 deletions .github/workflows/dev-build.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -37,6 +37,10 @@ jobs:
- name: Check out the repo
uses: actions/checkout@v4

# Enable multi-architecture builds via QEMU emulation
- name: Set up QEMU
uses: docker/setup-qemu-action@v3

# Enable advanced Docker build features (required for caching)
- name: Set up Docker Buildx
uses: docker/setup-buildx-action@v3
Expand Down Expand Up @@ -64,6 +68,7 @@ jobs:
context: .
file: ./Dockerfile
push: true
platforms: linux/amd64,linux/arm64
build-args: RELEASE_VERSION=${{ env.RELEASE_TAG }}
tags: ${{ env.REPOSITORY_NAMESPACE }}/${{ env.NMRKIT_REPOSITORY_NAME }}:${{ env.RELEASE_TAG }}
cache-from: type=registry,ref=${{ env.REPOSITORY_NAMESPACE }}/${{ env.NMRKIT_REPOSITORY_NAME }}:buildcache
Expand Down
5 changes: 5 additions & 0 deletions .github/workflows/prod-build.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -73,6 +73,10 @@ jobs:
- name: Check out the repo
uses: actions/checkout@v4

# Enable multi-architecture builds via QEMU emulation
- name: Set up QEMU
uses: docker/setup-qemu-action@v3

# Enable advanced Docker build features (required for caching)
- name: Set up Docker Buildx
uses: docker/setup-buildx-action@v3
Expand Down Expand Up @@ -100,6 +104,7 @@ jobs:
context: .
file: ./Dockerfile
push: true
platforms: linux/amd64,linux/arm64
build-args: RELEASE_VERSION=${{ env.RELEASE_TAG }}
tags: ${{ env.REPOSITORY_NAMESPACE }}/${{ env.NMRKIT_REPOSITORY_NAME }}:${{ env.RELEASE_TAG }}
cache-from: type=registry,ref=${{ env.REPOSITORY_NAMESPACE }}/${{ env.NMRKIT_REPOSITORY_NAME }}:buildcache
Expand Down
3 changes: 2 additions & 1 deletion Dockerfile
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,4 +1,5 @@
FROM continuumio/miniconda3:24.1.2-0 AS nmrkit-ms
ARG TARGETARCH

ENV PYTHON_VERSION=3.10
ENV OPENBABEL_VERSION=v3.1
Expand Down Expand Up @@ -30,7 +31,7 @@ RUN pip3 install rdkit

RUN python3 -m pip install -U pip

ENV JAVA_HOME=/usr/lib/jvm/java-17-openjdk-amd64/
ENV JAVA_HOME=/usr/lib/jvm/java-17-openjdk-${TARGETARCH}/
RUN export JAVA_HOME

RUN git clone "https://github.com/rinikerlab/lightweight-registration.git" lwreg
Expand Down