Require X-Sync-Trigger-Key header on /api/sync endpoint#2
Merged
Conversation
Co-authored-by: hajekj <8337913+hajekj@users.noreply.github.com> Agent-Logs-Url: https://github.com/NETWORG/github-organization-management/sessions/9cf4b695-d1a9-42f4-8a12-0d0008dbdfbf
Copilot
AI
changed the title
[WIP] Add synchronization trigger key requirement for sync endpoint
Require X-Sync-Trigger-Key header on /api/sync endpoint
Mar 21, 2026
hajekj
reviewed
Mar 21, 2026
Web/Controllers/SyncController.cs
Outdated
| return new UnauthorizedResult(); | ||
| } | ||
|
|
||
| if (!CryptographicOperations.FixedTimeEquals( |
Contributor
Author
There was a problem hiding this comment.
Done in b065b8c — replaced the CryptographicOperations.FixedTimeEquals byte-array comparison with string.Equals(providedKey.FirstOrDefault(), _syncTriggerKey, StringComparison.Ordinal) and removed the now-unused System.Security.Cryptography import.
Co-authored-by: hajekj <8337913+hajekj@users.noreply.github.com> Agent-Logs-Url: https://github.com/NETWORG/github-organization-management/sessions/d25337a6-f18c-49cc-91bd-404a92ac89d1
hajekj
approved these changes
Mar 21, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
SyncTriggerKeyconfig key toSyncController.cs(read from configuration)X-Sync-Trigger-Keyheader in the/api/syncendpoint – return 401 if missing or incorrect, 500 if key is not configuredstring.EqualswithStringComparison.Ordinalfor key comparisonSyncTriggerKeyis not configured; print startup warning viaProgram.csREADME.mdSecrets reference section to documentSyncTriggerKeyOriginal prompt
🔒 GitHub Advanced Security automatically protects Copilot coding agent pull requests. You can protect all pull requests by enabling Advanced Security for your repositories. Learn more about Advanced Security.