Skip to content

Replace vertical bars in Exit and Overall output#161

Merged
martialblog merged 3 commits into
mainfrom
replace-vertical-bar
Jun 23, 2026
Merged

Replace vertical bars in Exit and Overall output#161
martialblog merged 3 commits into
mainfrom
replace-vertical-bar

Conversation

@martialblog

Copy link
Copy Markdown
Member

This PR makes sure that any output does not contain vertical bars | so that the output won't conflict with the perfdata separator.

@martialblog martialblog self-assigned this Jun 19, 2026
@martialblog

Copy link
Copy Markdown
Member Author

@RincewindsHat I'm not 100% sure about this one. It's quite opinionated, on the other hand, I don't have to sanitize the strings in all check plugins.

What do you think?

@martialblog martialblog added this to the v1.0.0 milestone Jun 19, 2026
Comment thread exit.go Outdated

@RincewindsHat RincewindsHat left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sounds good, it does modify the output, which might be unexpected, but it also prevents accidently introducing that symbol (as has happened to me on some occasion).
Go for it

Comment thread exit.go
@martialblog martialblog force-pushed the replace-vertical-bar branch from d284197 to f256bc7 Compare June 22, 2026 18:32
Comment thread perfdata.go Outdated
@martialblog martialblog force-pushed the replace-vertical-bar branch from 38544f3 to e81f860 Compare June 23, 2026 09:12
Comment thread exit.go Outdated
@martialblog martialblog force-pushed the replace-vertical-bar branch from e81f860 to 31e1bb8 Compare June 23, 2026 11:08

@RincewindsHat RincewindsHat left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

good to go, I guess

@martialblog martialblog merged commit f0d9a25 into main Jun 23, 2026
2 checks passed
@martialblog martialblog deleted the replace-vertical-bar branch June 23, 2026 11:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants