Support the usage of special character in passwords#470
Merged
Conversation
afeefghannam89
changed the title
widhalmt
approved these changes
Jun 25, 2026
widhalmt
left a comment
widhalmt
left a comment
Member
There was a problem hiding this comment.
Looks good to me. This should get us rid of this "Umlauts" bug. Thanks!
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fix #282
Use command with argv to ensure that all special characters are handled correctly, including spaces and empty strings, for every password in this collection. For more info see
argv is already a fully constructed argument list, it is passed directly to execve() without any shlex processing. There is no splitting, quote parsing, or expansion. Every element is delivered exactly as provided, byte for byte. That's why using argv is the correct solution for handling arbitrary special characters, whereas the string-based approach (whether command or shell) must always go through some form of tokenization