fix(build): detect component name collisions during --plan#33
Merged
Conversation
The user-scope component collision guard only fired on a real apply (NDDEV_DRY_RUN=0). During a dry-run plan nddev::copy writes nothing, so the destination never materialized and the guard never tripped -- a plan reported success for inputs that the subsequent apply would reject. Add nddev::assert_component_graph, a source-side check run in copy_source_tree for both plan and apply, that rejects duplicate skill/command/agent destination basenames across the direct source tree and every installed plugin, with a diagnostic naming both colliding origins. Kept Bash 3.2-safe (no associative arrays). The on-disk guard in flatten_plugin_components stays for the complementary case a plan cannot see: a projected component overwriting a file already present in the target (e.g. restored user runtime state) on apply.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
The user-scope component collision guard only fired on a real apply (
NDDEV_DRY_RUN=0). During a dry-run plannddev::copywrites nothing, so the destination never materialized and the guard never tripped — a plan reported success for inputs the subsequent apply would reject.nddev::assert_component_graph(new) is a source-side check run incopy_source_treefor both plan and apply. It rejects duplicate skill/command/agent destination basenames across the direct source tree and every installed plugin, with a diagnostic naming both colliding origins. Bash 3.2-safe (no associative arrays). The on-disk guard inflatten_plugin_componentsstays for the complementary case a plan cannot see: a projected component overwriting a file already present in the target (e.g. restored user runtime state) on apply.Verification