fix: correct stale probe-timeout and 13->16 component counts#29
Merged
Conversation
The runtime CLI probe default timeout is 30s (version.sh DEFAULT_TIMEOUT, override-clamped 1-120s; a private test encodes the 30s cold-start tolerance), but build/manifest.json and SECURITY.md still advertised 3s -- 10x tighter than reality. The core toolkit ships 16 skills / 16 commands (the private marketplace-structure test asserts 16/16), but README.md, docs/architecture.md, and the core plugin README still said 13/13, omitting add-instructions, nddev-builder-orientation, and validate-components. Also couple marketplace.json's core-plugin version to build_version in the public contract validator (previously only plugin.json.version was checked). Docs/validator-only; no runtime behavior change; release-evidence rebound. Claude-Session: https://claude.ai/code/session_01Y29c9sJRhChvxDcUjab5Xo
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Corrects two documentation/contract facts that drifted from the code:
build/manifest.json:runtime_probe_policy.timeout_secondsandSECURITY.mdsaid 3s, but the code default is 30s (version.sh:DEFAULT_TIMEOUT, override-clamped 1-120s; the privatetest_runtime_probe_tolerates_a_slow_cold_startencodes 30s because 3s killed cold starts). Corrected both to 30s (with the 120s clamp noted in SECURITY.md).README.md,docs/architecture.md, and the core pluginREADME.mdsaid 13 skills / 13 commands; the tree ships 16/16 (the privatetest_marketplace_structureasserts 16/16). Added the missingadd-instructions,nddev-builder-orientation,validate-components(and commands/nddev-add-instructions,/nddev-orient,/nddev-validate).Defense-in-depth: the public contract validator now also couples
marketplace.json's core-plugin version tobuild_version(previously onlyplugin.json.versionwas checked).Docs/validator-only, no runtime behavior change, no version bump; release-evidence digest rebound.
https://claude.ai/code/session_01Y29c9sJRhChvxDcUjab5Xo