chore(actions): drop a helper nothing calls - #61
Merged
Conversation
RunStepsContaining shipped with the workflow model and was never called. That is the same shape this release spent its time removing everywhere else — a field required and never read, a check that could not fail for the reason it claimed — and leaving it in would be keeping the thing I had just finished arguing against. Worth naming the detection gap rather than implying it is covered: neither go vet nor staticcheck reports this. An exported identifier inside an internal/ package is not treated as unused, even though nothing outside the module can reach it, so this class is currently found by looking.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
actions.Job.RunStepsContainingshipped with the workflow model in #54 and was never called.That is the same shape this release spent its time removing everywhere else — a contract field required and never read, a check that could not fail for the reason it claimed. Leaving it in would be keeping the thing I had just finished arguing against.
The detection gap is worth naming rather than implying it is covered. Neither
go vetnorstaticcheckreports this: an exported identifier inside aninternal/package is not treated as unused, even though nothing outside the module can reach it. I found it by auditing every helper I had added, not by a gate.I did not add a checker for the class. That would be new scope past what the review and the plan called for, and it belongs in a decision of its own rather than smuggled into a cleanup.
Full gate:
gofmt,go vet,staticcheck v0.7.0, suite underumask 022 / 002 / 077,-race, all seven contract checkers. All green.